Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM fix for MML issue where Partial Wing not accounted for #5440

Merged
merged 2 commits into from
May 2, 2024
Merged

MM fix for MML issue where Partial Wing not accounted for #5440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8567d0
MM fix for MML issue where Partial Wing not accounted for
Sleet01 May 1, 2024
19a6ed3
Added clear explanation of each branch for PW handling
Sleet01 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions megamek/src/megamek/common/BattleArmor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,7 @@ public int getJumpMP(MPCalculationSetting mpCalculationSetting) {
mp++;
}

// MM is concerned with in-game conditions that impact Partial Wing mp
if ((game != null)) {
PlanetaryConditions conditions = game.getPlanetaryConditions();
boolean ignoreGameLessThanThin = mpCalculationSetting.ignoreWeather
Expand All @@ -528,6 +529,11 @@ && hasWorkingMisc(MiscType.F_PARTIAL_WING)
&& ignoreGameLessThanThin) {
mp++;
}
} else {
// MML just cares that the Partial Wing exists and is installed
if ((mp > 0) && hasWorkingMisc(MiscType.F_PARTIAL_WING)) {
mp++;
}
}
Sleet01 marked this conversation as resolved.
Show resolved Hide resolved

if ((mp > 0)
Expand Down
Loading