Allow configuring 'currentVersion' #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
allow-configuring-current-version
branch
2 times, most recently
from
87612be to
92f4c96
Compare
Rather than always obtaining the 'currentVersion' of the project from an environment variable, it can now be passed in via a CLI flag instead. Additionally, the validation for the version has been improved. It will now throw if the current version isn't a valid SemVer version, as our update logic depends upon it being valid. We also now ensure that the error message for a messing version is only printed when it was strictly required (it wasn't used for non-RC updates), and that the script terminates at that point. Closes #10
Gudahtt
force-pushed
the
allow-configuring-current-version
branch
from
92f4c96 to
454547b
Compare
Member
Author
|
Rebased to resolve conflicts |
brad-decker
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than always obtaining the 'currentVersion' of the project from an environment variable, it can now be passed in via a CLI flag instead.
Additionally, the validation for the version has been improved. It will now throw if the current version isn't a valid SemVer version, as our update logic depends upon it being valid. We also now ensure that the error message for a messing version is only printed when it was strictly required (it wasn't used for non-RC updates), and that the script terminates at that point.
Closes #10