Sepolia support #1041
Merged
Sepolia support #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hey @tommasini! Are there any tests we want to update? I found these: |
mcmire
reviewed
Jan 6, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
BREAKING: This update adds support for Sepolia (so that mobile can support it), and removes support for deprecated test networks Rinkeby, Kovan and Ropsten. The test cases were changed to use Sepolia and Goerli instead of the deprecated networks, and test coverage for NetworkController was increased. Finally the package `ethereumjs-common` was upgraded to version 2.6.1, which adds support for Sepolia (see changelog: <https://github.com/ethereumjs/ethereumjs-monorepo/blob/master/packages/common/CHANGELOG.md#261---2022-02-01>). Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
BREAKING: This update adds support for Sepolia (so that mobile can support it), and removes support for deprecated test networks Rinkeby, Kovan and Ropsten. The test cases were changed to use Sepolia and Goerli instead of the deprecated networks, and test coverage for NetworkController was increased. Finally the package `ethereumjs-common` was upgraded to version 2.6.1, which adds support for Sepolia (see changelog: <https://github.com/ethereumjs/ethereumjs-monorepo/blob/master/packages/common/CHANGELOG.md#261---2022-02-01>). Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Added support for Sepolia test network.
Description
It was added Sepolia test network support to our Network Controller and Transaction controller, also on Transaction controller it was updated the package ethereumjs-common to version 2.6.1 to support Sepolia network
BREAKING:
This update removes all the deprecated test networks, rinkeby, kovan and ropsten from this repo
Also, it allows to implement this PR to MetaMask Mobile support Sepolia
CHANGED:
The test cases were changed to use sepolia and goerli instead of the deprecated networks.
Also it was increased the test coverage of network controller
DEPRECATED:
Test networks, kovan, ropsten and rinkeby
Checklist
Issue
Resolves #MetaMask/metamask-mobile#5406