refactor(permission-controller): Refactor "any" typecasts

Either replaces `any` with `@ts-expect-error` directives or leaves them
in place without a TODO to replace them. All remaining instances of
`any` are defensible.

packages/permission-controller/src/Caveat.test.ts

@@ -9,7 +9,6 @@ describe('decorateWithCaveats', () => {
     const caveatSpecifications = {
       reverse: {
         type: 'reverse',
-        // TODO: Replace `any` with type
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         decorator: (method: any, _caveat: any) => async () => {
           return (await method()).reverse();
@@ -46,15 +45,13 @@ describe('decorateWithCaveats', () => {
     const caveatSpecifications = {
       reverse: {
         type: 'reverse',
-        // TODO: Replace `any` with type
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         decorator: (method: any, _caveat: any) => async () => {
           return (await method()).reverse();
         },
       },
       slice: {
         type: 'slice',
-        // TODO: Replace `any` with type
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         decorator: (method: any, caveat: any) => async () => {
           return (await method()).slice(0, caveat.value);
@@ -114,7 +111,6 @@ describe('decorateWithCaveats', () => {
     const caveatSpecifications = {
       reverse: {
         type: 'reverse',
-        // TODO: Replace `any` with type
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         decorator: (method: any, _caveat: any) => async () => {
           return (await method()).reverse();

packages/permission-controller/src/Caveat.ts

@@ -82,15 +82,12 @@ export type CaveatDecorator<ParentCaveat extends CaveatConstraint> = (
  * @template Decorator - The {@link CaveatDecorator} to extract a caveat value
  * type from.
  */
-// TODO: Replace `any` with type
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 type ExtractCaveatValueFromDecorator<Decorator extends CaveatDecorator<any>> =
   Decorator extends (
-    // TODO: Replace `any` with type
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     decorated: any,
     caveat: infer ParentCaveat,
-    // TODO: Replace `any` with type
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
   ) => AsyncRestrictedMethod<any, any>
     ? ParentCaveat extends CaveatConstraint
@@ -129,7 +126,6 @@ export type CaveatSpecificationBase = {
    * performed. Although caveats can also be validated by permission validators,
    * validating caveat values separately is strongly recommended.
    */
-  // TODO: Replace `any` with type
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   validator?: CaveatValidator<any>;
 };
@@ -140,7 +136,6 @@ export type RestrictedMethodCaveatSpecificationConstraint =
      * The decorator function used to apply the caveat to restricted method
      * requests.
      */
-    // TODO: Replace `any` with type
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     decorator: CaveatDecorator<any>;
   };
@@ -180,7 +175,6 @@ type CaveatSpecificationBuilderOptions<
  * tailored to their requirements.
  */
 export type CaveatSpecificationBuilder<
-  // TODO: Replace `any` with type
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   Options extends CaveatSpecificationBuilderOptions<any, any>,
   Specification extends CaveatSpecificationConstraint,
@@ -192,7 +186,6 @@ export type CaveatSpecificationBuilder<
  */
 export type CaveatSpecificationBuilderExportConstraint = {
   specificationBuilder: CaveatSpecificationBuilder<
-    // TODO: Replace `any` with type
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     CaveatSpecificationBuilderOptions<any, any>,
     CaveatSpecificationConstraint
@@ -220,7 +213,6 @@ export type CaveatSpecificationMap<
  */
 export type ExtractCaveats<
   CaveatSpecification extends CaveatSpecificationConstraint,
-  // TODO: Replace `any` with type
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
 > = CaveatSpecification extends any
   ? CaveatSpecification extends RestrictedMethodCaveatSpecificationConstraint

packages/permission-controller/src/Permission.ts

@@ -118,9 +118,7 @@ export type ValidPermission<
  */
 type ExtractArrayMembers<ArrayType> = ArrayType extends []
   ? never
-  : // TODO: Replace `any` with type
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  ArrayType extends any[] | readonly any[]
+  : ArrayType extends unknown[] | readonly unknown[]
   ? ArrayType[number]
   : never;
 
@@ -209,9 +207,7 @@ export type RequestedPermissions = Record<TargetName, RequestedPermission>;
  */
 type RestrictedMethodContext = Readonly<{
   origin: OriginString;
-  // TODO: Replace `any` with type
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [key: string]: any;
+  [key: string]: unknown;
 }>;
 
 export type RestrictedMethodParameters = Json[] | Record<string, Json>;
@@ -265,9 +261,10 @@ export type RestrictedMethod<
   | AsyncRestrictedMethod<Params, Result>;
 
 export type ValidRestrictedMethod<
-  // TODO: Replace `any` with type
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  MethodImplementation extends RestrictedMethod<any, any>,
+  MethodImplementation extends RestrictedMethod<
+    RestrictedMethodParameters,
+    Json
+  >,
 > = MethodImplementation extends (args: infer Options) => Json | Promise<Json>
   ? Options extends RestrictedMethodOptions<RestrictedMethodParameters>
     ? MethodImplementation
@@ -404,7 +401,6 @@ type PermissionSpecificationBase<Type extends PermissionType> = {
    * used, and the validator function (if specified) will be called on newly
    * constructed permissions.
    */
-  // TODO: Replace `any` with type
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   factory?: PermissionFactory<any, Record<string, unknown>>;
 
@@ -423,7 +419,6 @@ type PermissionSpecificationBase<Type extends PermissionType> = {
    *
    * If the side-effect action fails, the permission that triggered it is revoked.
    */
-  // TODO: Replace `any` with type
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   sideEffect?: PermissionSideEffect<any, any>;
 
@@ -449,7 +444,6 @@ export type RestrictedMethodSpecificationConstraint =
      * The implementation of the restricted method that the permission
      * corresponds to.
      */
-    // TODO: Replace `any` with type
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     methodImplementation: RestrictedMethod<any, any>;
   };
@@ -469,7 +463,6 @@ export type EndowmentSpecificationConstraint =
      * permission is invoked, after which the host can apply the endowments to
      * the requesting subject in the intended manner.
      */
-    // TODO: Replace `any` with type
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     endowmentGetter: EndowmentGetter<any>;
   };
@@ -511,7 +504,6 @@ type PermissionSpecificationBuilderOptions<
  */
 export type PermissionSpecificationBuilder<
   Type extends PermissionType,
-  // TODO: Replace `any` with type
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   Options extends PermissionSpecificationBuilderOptions<any, any, any>,
   Specification extends PermissionSpecificationConstraint & {
@@ -527,7 +519,6 @@ export type PermissionSpecificationBuilderExportConstraint = {
   targetName: string;
   specificationBuilder: PermissionSpecificationBuilder<
     PermissionType,
-    // TODO: Replace `any` with type
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     PermissionSpecificationBuilderOptions<any, any, any>,
     PermissionSpecificationConstraint