Fix lint

Author: OGPoyraz

packages/transaction-controller/src/TransactionController.ts

@@ -3892,10 +3892,10 @@ export class TransactionController extends BaseController<
     gasFeeEstimatesLoaded?: boolean;
     layer1GasFee?: Hex;
   }) {
-    const txMeta = this.getTransaction(transactionId) as TransactionMeta;
+    const transaction = this.getTransaction(transactionId) as TransactionMeta;
     const isEIP1559Compatible =
-      txMeta?.txParams?.type !== TransactionEnvelopeType.legacy &&
-      (await this.getEIP1559Compatibility(txMeta?.networkClientId));
+      transaction?.txParams?.type !== TransactionEnvelopeType.legacy &&
+      (await this.getEIP1559Compatibility(transaction?.networkClientId));
 
     this.#updateTransactionInternal(
       { transactionId, skipHistory: true },

packages/transaction-controller/src/helpers/GasFeePoller.test.ts

@@ -362,7 +362,7 @@ describe('updateTransactionGasFees', () => {
       ...TRANSACTION_META_MOCK,
     };
 
-    await updateTransactionGasFees({
+    updateTransactionGasFees({
       txMeta,
       gasFeeEstimates: FEE_MARKET_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
       isEIP1559Compatible: true,
@@ -377,7 +377,7 @@ describe('updateTransactionGasFees', () => {
       ...TRANSACTION_META_MOCK,
     };
 
-    await updateTransactionGasFees({
+    updateTransactionGasFees({
       txMeta,
       gasFeeEstimatesLoaded: true,
       isEIP1559Compatible: true,
@@ -386,7 +386,7 @@ describe('updateTransactionGasFees', () => {
 
     expect(txMeta.gasFeeEstimatesLoaded).toBe(true);
 
-    await updateTransactionGasFees({
+    updateTransactionGasFees({
       txMeta,
       gasFeeEstimatesLoaded: false,
       isEIP1559Compatible: true,
@@ -402,7 +402,7 @@ describe('updateTransactionGasFees', () => {
       ...TRANSACTION_META_MOCK,
     };
 
-    await updateTransactionGasFees({
+    updateTransactionGasFees({
       txMeta,
       layer1GasFee: layer1GasFeeMock,
       isEIP1559Compatible: true,
@@ -427,7 +427,7 @@ describe('updateTransactionGasFees', () => {
         userFeeLevel,
       };
 
-      await updateTransactionGasFees({
+      updateTransactionGasFees({
         txMeta,
         gasFeeEstimates: FEE_MARKET_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
         isEIP1559Compatible: true,
@@ -464,15 +464,13 @@ describe('updateTransactionGasFees', () => {
         },
       };
 
-      await updateTransactionGasFees({
+      updateTransactionGasFees({
         txMeta,
         gasFeeEstimates: FEE_MARKET_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
         isEIP1559Compatible: true,
         isTxParamsGasFeeUpdatesEnabled: true,
       });
 
-      await flushPromises();
-
       expect(txMeta.txParams.maxFeePerGas).toBe(
         dappSuggestedOrCustomMaxFeePerGas,
       );
@@ -499,7 +497,7 @@ describe('updateTransactionGasFees', () => {
         userFeeLevel,
       };
 
-      await updateTransactionGasFees({
+      updateTransactionGasFees({
         txMeta,
         gasFeeEstimates: FEE_MARKET_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
         isEIP1559Compatible: true,
@@ -522,7 +520,7 @@ describe('updateTransactionGasFees', () => {
           userFeeLevel: GasFeeEstimateLevel.Low,
         };
 
-        await updateTransactionGasFees({
+        updateTransactionGasFees({
           txMeta,
           gasFeeEstimates: FEE_MARKET_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
           isEIP1559Compatible: true,
@@ -546,7 +544,7 @@ describe('updateTransactionGasFees', () => {
           userFeeLevel: GasFeeEstimateLevel.Low,
         };
 
-        await updateTransactionGasFees({
+        updateTransactionGasFees({
           txMeta,
           gasFeeEstimates: GAS_PRICE_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
           isEIP1559Compatible: true,
@@ -568,7 +566,7 @@ describe('updateTransactionGasFees', () => {
           userFeeLevel: GasFeeEstimateLevel.Low,
         };
 
-        await updateTransactionGasFees({
+        updateTransactionGasFees({
           txMeta,
           gasFeeEstimates: LEGACY_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
           isEIP1559Compatible: true,
@@ -586,8 +584,6 @@ describe('updateTransactionGasFees', () => {
     });
 
     describe('on non-EIP-1559 compatible chains', () => {
-      const getEIP1559CompatibilityMock = async () => false;
-
       it('with fee market gas fee estimates', async () => {
         const txMeta = {
           ...TRANSACTION_META_MOCK,
@@ -598,7 +594,7 @@ describe('updateTransactionGasFees', () => {
           userFeeLevel: GasFeeEstimateLevel.Medium,
         };
 
-        await updateTransactionGasFees({
+        updateTransactionGasFees({
           txMeta,
           gasFeeEstimates: FEE_MARKET_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
           isEIP1559Compatible: false,
@@ -623,7 +619,7 @@ describe('updateTransactionGasFees', () => {
           userFeeLevel: GasFeeEstimateLevel.Low,
         };
 
-        await updateTransactionGasFees({
+        updateTransactionGasFees({
           txMeta,
           gasFeeEstimates: GAS_PRICE_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
           isEIP1559Compatible: false,
@@ -647,7 +643,7 @@ describe('updateTransactionGasFees', () => {
           userFeeLevel: GasFeeEstimateLevel.Low,
         };
 
-        await updateTransactionGasFees({
+        updateTransactionGasFees({
           txMeta,
           gasFeeEstimates: LEGACY_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
           isEIP1559Compatible: false,
@@ -674,7 +670,7 @@ describe('updateTransactionGasFees', () => {
         },
       };
 
-      await updateTransactionGasFees({
+      updateTransactionGasFees({
         txMeta,
         gasFeeEstimates: FEE_MARKET_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
         isEIP1559Compatible: true,
@@ -704,7 +700,7 @@ describe('updateTransactionGasFees', () => {
         },
       };
 
-      await updateTransactionGasFees({
+      updateTransactionGasFees({
         txMeta,
         gasFeeEstimates: LEGACY_GAS_FEE_ESTIMATES_MOCK as GasFeeEstimates,
         isEIP1559Compatible: false,
@@ -731,7 +727,7 @@ describe('updateTransactionGasFees', () => {
         },
       };
 
-      await updateTransactionGasFees({
+      updateTransactionGasFees({
         txMeta,
         gasFeeEstimates: undefined,
         isEIP1559Compatible: true,
@@ -747,7 +743,7 @@ describe('updateTransactionGasFees', () => {
         ...TRANSACTION_META_MOCK,
       };
 
-      await updateTransactionGasFees({
+      updateTransactionGasFees({
         txMeta,
         gasFeeEstimates: undefined,
         gasFeeEstimatesLoaded: true,

packages/transaction-controller/src/helpers/GasFeePoller.ts

@@ -25,7 +25,6 @@ import {
   GasFeeEstimateLevel,
   GasFeeEstimateType,
   TransactionStatus,
-  TransactionEnvelopeType,
 } from '../types';
 import { getGasFeeFlow } from '../utils/gas-flow';
 import { getTransactionLayer1GasFee } from '../utils/layer1-gas-fee-flow';