Add EIP-1559 compatibility validation for transaction creation #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistevam
commented
Sep 21, 2023
OGPoyraz
previously approved these changes
Sep 21, 2023
matthewwalsh0
previously approved these changes
Sep 21, 2023
Contributor
Author
|
Only merge after #1690 to use |
vinistevam
dismissed stale reviews from matthewwalsh0 and OGPoyraz
via
666702a
OGPoyraz
approved these changes
Sep 27, 2023
matthewwalsh0
approved these changes
Sep 27, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Explanation This PR aims to include a validation existent in the Extension in the `TransactionController` core. The validation gets the current network and current account to check if they support EIP-1559 transactions. If the transaction is an EIP-1559 transaction, meaning it contains `maxFeePerGas` and `maxPriorityFeePerGas` values, but the network or account does not support EIP-1559, then an error is thrown. In order to support it two callbacks are passed to the controller constructor `getCurrentAccountEIP1559Compatibility` and `getCurrentNetworkEIP1559Compatibility`. ## Changelog ### `@metamask/transaction-controller` - **BREAKING**: Add required `getCurrentAccountEIP1559Compatibility` and `getCurrentNetworkEIP1559Compatibility` callback arguments to constructor.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Explanation This PR aims to include a validation existent in the Extension in the `TransactionController` core. The validation gets the current network and current account to check if they support EIP-1559 transactions. If the transaction is an EIP-1559 transaction, meaning it contains `maxFeePerGas` and `maxPriorityFeePerGas` values, but the network or account does not support EIP-1559, then an error is thrown. In order to support it two callbacks are passed to the controller constructor `getCurrentAccountEIP1559Compatibility` and `getCurrentNetworkEIP1559Compatibility`. ## Changelog ### `@metamask/transaction-controller` - **BREAKING**: Add required `getCurrentAccountEIP1559Compatibility` and `getCurrentNetworkEIP1559Compatibility` callback arguments to constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to include a validation existent in the Extension in the
TransactionControllercore. The validation gets the current network and current account to check if they support EIP-1559 transactions. If the transaction is an EIP-1559 transaction, meaning it containsmaxFeePerGasandmaxPriorityFeePerGasvalues, but the network or account does not support EIP-1559, then an error is thrown.In order to support it two callbacks are passed to the controller constructor
getCurrentAccountEIP1559CompatibilityandgetCurrentNetworkEIP1559Compatibility.Changelog
@metamask/transaction-controllergetCurrentAccountEIP1559CompatibilityandgetCurrentNetworkEIP1559Compatibilitycallback arguments to constructor.Checklist