Release 78.0.0 #1708

OGPoyraz · 2023-09-25T10:09:25Z

See change logs

mikesposito · 2023-09-25T10:42:07Z

We should change the title of this PR to Release 78.0.0 for the CI to properly flag this as a release

mikesposito · 2023-09-25T10:43:28Z

packages/assets-controllers/CHANGELOG.md

+- **BREAKING**: `TokensController.addToken` now accepts a single options object
+  ```
+    {
+      address: string;
+      symbol: string;
+      decimals: number;
+      name?: string;
+      image?: string;
+      interactingAddress?: string;
+      networkClientId?: NetworkClientId;
+    }
+  ```  
+- **CHANGED**: `TokensController.addToken` will use the chain ID value derived from state for `networkClientId` if provided
+- **CHANGED**: `TokensController.addTokens` now accepts an optional `networkClientId` as the last parameter
+- **CHANGED**: `TokensController.addTokens` will use the chain ID value derived from state for `networkClientId` if provided
+- **CHANGED**: `TokensController.watchAsset` options now accepts optional `networkClientId` which is used to get the ERC-20 token name if provided


Can we link PRs related to these changes?

Fixed in a4313b4

OGPoyraz · 2023-09-25T11:00:42Z

We should change the title of this PR to Release 78.0.0 for the CI to properly flag this as a release

Thanks @mikesposito

jiexi

@metamask/asset-controllers LGTM. Thank you for cutting this release 💪

packages/keyring-controller/CHANGELOG.md

packages/assets-controllers/CHANGELOG.md

Gudahtt · 2023-09-25T18:15:24Z

#1633 has been merged now as well, which includes many breaking changes. We'll need to expand the scope of this release to include a few more things

jiexi · 2023-09-25T20:45:29Z

I'm working on getting #1633 included in this release right now

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

packages/accounts-controller/CHANGELOG.md

packages/address-book-controller/CHANGELOG.md

packages/accounts-controller/CHANGELOG.md

packages/assets-controllers/CHANGELOG.md

packages/network-controller/CHANGELOG.md

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Gudahtt

LGTM!

Gudahtt

Just noticed that each of these peer dependency bumps is just called a dependency bump in the change entry, which might be confusing (as that wouldn't normally be breaking). I've added a suggestion to re-word each one to "peer dependency"

packages/transaction-controller/CHANGELOG.md

packages/selected-network-controller/CHANGELOG.md

packages/gas-fee-controller/CHANGELOG.md

packages/ens-controller/CHANGELOG.md

packages/assets-controllers/CHANGELOG.md

See change logs --------- Co-authored-by: Alex Donesky <adonesky@gmail.com> Co-authored-by: Jiexi Luan <jiexiluan@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Release 78.0.0

a509f4d

OGPoyraz requested a review from a team as a code owner September 25, 2023 10:09

OGPoyraz added 2 commits September 25, 2023 12:26

Readme fixes

12d63d7

Fix dependency versions

ecca162

OGPoyraz force-pushed the release/78.0.0 branch from 60a4ec6 to ecca162 Compare September 25, 2023 10:28

OGPoyraz added 2 commits September 25, 2023 12:31

yarn dedupe

497c677

fix changelog

e7d99c8

mikesposito reviewed Sep 25, 2023

View reviewed changes

OGPoyraz changed the title ~~Release/78.0.0~~ Release 78.0.0 Sep 25, 2023

OGPoyraz and others added 2 commits September 25, 2023 13:02

Fix changelog for assets-controller

a4313b4

Merge branch 'main' into release/78.0.0

6ff4194

jiexi previously approved these changes Sep 25, 2023

View reviewed changes

Gudahtt reviewed Sep 25, 2023

View reviewed changes

packages/keyring-controller/CHANGELOG.md Show resolved Hide resolved

Gudahtt reviewed Sep 25, 2023

View reviewed changes

packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved

adonesky1 added 2 commits September 25, 2023 13:42

Merge branch 'main' into release/78.0.0

3e38602

update changelog

2bf19e2

adonesky1 dismissed jiexi’s stale review via 2bf19e2 September 25, 2023 19:01

adonesky1 and others added 3 commits September 25, 2023 14:09

fix changelog

9a2a03c

bump keyring-controller version

3de5d61

Bump NetworkController v13.0.0

55735e2

jiexi added 4 commits September 25, 2023 14:08

TransactionController

90c67ed

EnsController

41fc71e

Controller Utils

64990ca

Merge remote-tracking branch 'origin/release/78.0.0' into release/78.0.0

58d05da

jiexi requested a review from a team as a code owner September 25, 2023 21:20

Update packages/assets-controllers/CHANGELOG.md

0cf5f03

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Gudahtt reviewed Sep 25, 2023

View reviewed changes

packages/accounts-controller/CHANGELOG.md Outdated Show resolved Hide resolved

yarn

3d7b268

Gudahtt reviewed Sep 25, 2023

View reviewed changes

packages/address-book-controller/CHANGELOG.md Show resolved Hide resolved

jiexi added 7 commits September 25, 2023 15:43

Release accounts-controller as major

57ea067

Release address-book-controller as patch

0a7cefb

release all consumers of major dep bumps

4244a0f

Bump internally used

4a299fd

yarn

2ce3132

changelog

c0b375e

missed a changelog

3a0246b

Gudahtt reviewed Sep 25, 2023

View reviewed changes

packages/accounts-controller/CHANGELOG.md Outdated Show resolved Hide resolved

packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved

Gudahtt reviewed Sep 25, 2023

View reviewed changes

packages/network-controller/CHANGELOG.md Outdated Show resolved Hide resolved

OGPoyraz and others added 5 commits September 26, 2023 08:48

Update packages/accounts-controller/CHANGELOG.md

7c588ef

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Update removed to changed in network-controller changelog

84faabc

Update remove to removed in transaction-controller changelog

fbaac1a

Fix package links

d25de03

Fix network-controller changelog lint

4e3b3da

OGPoyraz force-pushed the release/78.0.0 branch from 82c50a5 to 4e3b3da Compare September 26, 2023 07:10

Mark bump dependency changes as BC

4a1975c

Gudahtt previously approved these changes Sep 26, 2023

View reviewed changes

Gudahtt reviewed Sep 26, 2023

View reviewed changes

OGPoyraz dismissed Gudahtt’s stale review via 6f7da85 September 26, 2023 12:04

Update changelogs for network controller bump

c96a938

OGPoyraz force-pushed the release/78.0.0 branch from 6f7da85 to c96a938 Compare September 26, 2023 12:05

Gudahtt approved these changes Sep 26, 2023

View reviewed changes

Mrtenz approved these changes Sep 26, 2023

View reviewed changes

Gudahtt merged commit 55b6636 into main Sep 26, 2023

Gudahtt deleted the release/78.0.0 branch September 26, 2023 12:20

MajorLift pushed a commit that referenced this pull request Oct 11, 2023

Release 78.0.0 (#1708)

854db80

See change logs --------- Co-authored-by: Alex Donesky <adonesky@gmail.com> Co-authored-by: Jiexi Luan <jiexiluan@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>

MajorLift pushed a commit that referenced this pull request Oct 11, 2023

Release 78.0.0 (#1708)

af67cfc

See change logs --------- Co-authored-by: Alex Donesky <adonesky@gmail.com> Co-authored-by: Jiexi Luan <jiexiluan@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Uh oh!

Release 78.0.0 #1708

Release 78.0.0 #1708

Uh oh!

Conversation

OGPoyraz commented Sep 25, 2023

Uh oh!

mikesposito commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikesposito Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

OGPoyraz Sep 25, 2023

Choose a reason for hiding this comment

Uh oh!

OGPoyraz commented Sep 25, 2023

Uh oh!

jiexi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Gudahtt commented Sep 25, 2023

Uh oh!

jiexi commented Sep 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

Gudahtt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mikesposito commented Sep 25, 2023 •

edited

Loading