Release 124.0.0 #4039
Merged
Release 124.0.0 #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See updates to package manifests and changelogs.
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@keystonehq/bc-ur-registry-eth@0.9.1, npm/typedoc-plugin-missing-exports@2.2.0 |
mcmire
commented
Mar 9, 2024
MajorLift
reviewed
Mar 9, 2024
MajorLift
reviewed
Mar 9, 2024
MajorLift
reviewed
Mar 9, 2024
MajorLift
reviewed
Mar 9, 2024
MajorLift
reviewed
Mar 9, 2024
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Mrtenz
reviewed
Mar 12, 2024
|
|
||
| ### Added | ||
|
|
||
| - **BREAKING**: Add ESM build ([#3998](https://github.com/MetaMask/core/pull/3998)) |
There was a problem hiding this comment.
Nit: I noticed that the colon is sometimes bold and sometimes not. Not a big deal though. 😅
There was a problem hiding this comment.
Ah, we still need to solve MetaMask/auto-changelog#109.
Mrtenz
approved these changes
Mar 12, 2024
7 tasks
MarioAslau
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 22, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Update Signature Controller to v^14 Changelog: https://github.com/MetaMask/core/blob/%40metamask/signature-controller%4016.0.0/packages/signature-controller/CHANGELOG.md These two peer dependencies: * BREAKING: Bump dependency and peer dependency on @metamask/keyring-controller to ^14.0.0 (MetaMask/core#4039) * BREAKING: Bump dependency and peer dependency on @metamask/approval-controller to ^6.0.0 (MetaMask/core#4039) These two controllers are being used inside Signature Controller to import types. These types have not been changed during the latest upgrades to these controllers, thus not being a breaking changes for Signature Controller V14. ## **Related issues** - #9649 ## **Manual testing steps** 1. Turn on MetaMask and log into wallet 2. Go to Settings > Advanced > Turn on Eth_sign requests 3. Go to mobile browser and access https://metamask.github.io/test-dapp/ 4. Use MetaMask wallet and Connect Wallet 5. Scroll down and test signing in: Eth Sign, Perosnal Sign, Sign Typed Data, Sign Typed Data V3, Sign Typed Data V4, Sign Permit, Sign in with Ethereum 6. Verify each of the singings where the button is present ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/MetaMask/metamask-mobile/assets/15312578/310565cd-5ca6-481b-8506-dc482a6bc2c1 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: tommasini <tommasini15@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release is large and includes a fair number of breaking changes:
@metamask/base-controller. This forces releasing all of the controller packages.exportsfield has been added to facilitate this. This means that importing subpaths is no longer allowed. This forces releasing every package.