feat(permission-controller): Re-throw all well-formed errors #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
rekmarks-re-throw-permission-validation-errors
branch
2 times, most recently
from
01612bb to
28f86e9
Compare
Re-throws all well-formed errors during that occur during permission validation in `requestPermissions()`. Also restores 100% unit test coverage.
rekmarks
force-pushed
the
rekmarks-re-throw-permission-validation-errors
branch
from
28f86e9 to
442d128
Compare
hmalik88
reviewed
Apr 17, 2024
| const callActionSpy = jest | ||
| .spyOn(messenger, 'call') | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| .mockImplementationOnce(async (...args: any) => { |
There was a problem hiding this comment.
why couldn't args be typed properly?
There was a problem hiding this comment.
I tried to add a more specific type, but got a pretty inscrutable error as a result. I could try to debug that, but if we somehow mess up these mocks, the tests ought to fail in unexpected ways, which we would immediately discover. It probably could be done, but I don't think it's worth our time.
Edit: This is also just what we already do for similar mocks throughout this file, and I remove all of the TODOs to remove these any's here: #4171
david0xd
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When re-throwing validation errors in
requestPermissions(), include original message from all well-formed errors. Also restore 100% unit test coverage.Changelog
@metamask/permission-controllerChecklist