bump @metamask/utils to 9.3.0
#4814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
approved these changes
Oct 17, 2024
legobeat
reviewed
Oct 17, 2024
legobeat
previously approved these changes
Oct 17, 2024
owencraston
previously approved these changes
Oct 17, 2024
FrederikBolding
previously approved these changes
Oct 18, 2024
Gudahtt
previously approved these changes
Oct 21, 2024
|
Whoops, looks like there are conflicts to resolve. Note that despite the long list of code owners here, only a review from the wallet framework team is required. Once this has been updated, please tag that team for a re-review and we can get this merged fairly without more conflicts |
hmalik88
dismissed stale reviews from Gudahtt, FrederikBolding, owencraston, and legobeat
via
fce8d69
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/utils@9.2.1 |
legobeat
suggested changes
Oct 22, 2024
| "@metamask/rpc-errors": "^7.0.0", | ||
| "@metamask/utils": "^9.1.0", | ||
| "@metamask/json-rpc-engine": "^9.0.3", | ||
| "@metamask/rpc-errors": "^6.3.1", |
There was a problem hiding this comment.
Why are these two packages being downgraded here? It could be related to the failing test?
Same for @metamask/rate-limit-controller and @metamask/transaction-controller.
Failing lint should be a straightforward fix by ensuring version alignment as the error message tells us.
|
Closing in favor of #4831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping utils to
9.3.0, pre-cursor to #4809