-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 236.0.0 #4870
Release 236.0.0 #4870
Conversation
I'm considering simplifying this by just releasing assets-controllers, and intentionally skipping other packages. If anyone can help verify it's safe to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Most of these releases (other than
@metamask/assets-controllers
itself) should be patch version bumps instead.- The only potential breaking changes in these changelogs are the major version bumps for
@metamask/utils
and@metamask/eth-sig-util
(@metamask/{keyring-controller,message-manager}
). These updates should be evaluated based on their effect on the packages, and if they are indeed breaking changes they should be noted as such in the changelogs. If not, the package should not be bumped by a major version. - For reference: https://github.com/MetaMask/core/blob/main/docs/reviewing-release-prs.md
- The only potential breaking changes in these changelogs are the major version bumps for
- Major version bumps in peer dependencies are always breaking changes, and should be recorded in the changelogs. Non-major bumps in peer dependencies should not be applied at all in the package.json
peerDependencies
section nor in the changelog. Updating thedevDependencies
entry is still necessary. - Version bumps applied by this PR should also be added to the changelogs.
- The notifications team packages (
@metamask/{notification-services,profile-sync}-controller
) are pre-release (v0.x.x), so major releases should bump a "minor" version and minor/patch releases a "patch" version.
I'm considering simplifying this by just releasing assets-controllers, and intentionally skipping other packages. If anyone can help verify it's safe to do so.
When creating major releases, feature teams are expected to also publish unreleased changes in peer dependencies (especially for peerDeps being bumped) and dependents, and deliver them to the clients.
Previous lapses in these follow-up tasks have resulted in significant package version disparities in the clients, and we're working on tooling (https://github.com/MetaMask/MetaMask-planning/issues/2988) and guidelines to ensure that package versions will stay aligned in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos
@bergeron Can we release |
Can you explain how this is different from what's in the PR? I'm just running the release tool and categorizing each entry it puts in the changelog. Is there something additional to do on top? |
Looking deeper into the changes I think they're both non breaking for consumers |
13d5fe1
to
7f5fb69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally don't include dev dependency updates in changelogs, but they can be included for reference if relevant to the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR bumps @metamask/controller-utils
from ^11.4.1
to ^11.4.2
. This needs to be reflected in the changelogs.
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your patience.
This is intended to release the asset controllers. I also included other controllers the release tool thought should be included