feat(multichain-account-service): add transient state #6401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
force-pushed
the
feat/multichain-account-service-transient-state
branch
from
7baa727 to
8159614
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
fabiobozzo
reviewed
Aug 29, 2025
Contributor
fabiobozzo
left a comment
fabiobozzo
left a comment
There was a problem hiding this comment.
LGTM. One question: where exactly do you "reduce" the in-progress state of each wallet to a 'global' service state? aka "at least one wallet alignment is in progress" ?
fabiobozzo
reviewed
Aug 29, 2025
| } from './MultichainAccountService'; | ||
| import type { MultichainAccountWalletTransientState } from './MultichainAccountWallet'; | ||
|
|
||
| export type MultichainAccountServiceTransientState = { |
Contributor
Author
I didn't change anything for this, so we loop through every wallet instances and use |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Testing transient state for services.
References
N/A
Checklist