Skip to content

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Sep 4, 2025

Explanation

This PR migrates EnsController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates EnsController to @metamask/messenger, updates metadata/types, and adjusts tests, configs, and docs accordingly.

  • Ens Controller:
    • Migrate from @metamask/base-controller messenger to @metamask/messenger and use @metamask/base-controller/next types (StateMetadata, controller actions/events).
    • Replace messagingSystem.call with messenger.call and update messenger types (EnsControllerActions, EnsControllerEvents).
    • Rename metadata anonymous to includeInDebugSnapshot.
  • Tests (packages/ens-controller/src/EnsController.test.ts):
    • Switch to new Messenger API: create root/controller messengers, delegate actions, and update types/util imports.
  • Dependencies/Config:
    • Add @metamask/messenger dependency; add TS project references to packages/messenger.
    • Update README dependency graph to include @metamask/messenger links for base_controller, ens_controller, and new eip_7702_internal_rpc_middleware edge.
    • Adjust ESLint warning threshold for import-x/order in EnsController.test.ts.
    • Update yarn.lock.
  • Changelog:
    • Note breaking change to use new Messenger and metadata rename; export EnsControllerActions and EnsControllerEvents.

Written by Cursor Bugbot for commit e37bf9a. This will update automatically on new commits. Configure here.

@mikesposito mikesposito marked this pull request as ready for review September 4, 2025 10:53
@mikesposito mikesposito requested review from a team as code owners September 4, 2025 10:53
@mikesposito mikesposito mentioned this pull request Sep 4, 2025
43 tasks
@mcmire
Copy link
Contributor

mcmire commented Oct 7, 2025

Need to resolve conflicts :(

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito enabled auto-merge October 27, 2025 10:38
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
@FrederikBolding FrederikBolding removed this pull request from the merge queue due to the queue being cleared Oct 27, 2025
@mikesposito mikesposito added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 1b28614 Oct 27, 2025
256 of 257 checks passed
@mikesposito mikesposito deleted the mikesposito/messenger/ens-controller branch October 27, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants