Skip to content

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Sep 9, 2025

Explanation

This PR migrates NameController to the new @metamask/messenger message bus, as opposed to the one exported from @metamask/base-controller.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates NameController to the new @metamask/messenger, renames metadata anonymous to includeInDebugSnapshot, and updates imports, tests, and build references.

  • NameController:
    • Migrate to @metamask/messenger (Messenger) and replace RestrictedMessenger; update generics/types.
    • Switch imports to @metamask/base-controller/next.
    • Rename metadata anonymous -> includeInDebugSnapshot; update stateMetadata and usages.
    • Update tests to reflect new metadata key and deriveStateFromMetadata import path.
  • Package/Build:
    • Add dependency @metamask/messenger and TypeScript project references.
    • Update README dependency graph to include messenger links.
  • Changelog:
    • Document breaking changes for messenger migration and metadata rename.

Written by Cursor Bugbot for commit d84e281. This will update automatically on new commits. Configure here.

mcmire
mcmire previously approved these changes Sep 10, 2025
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/name-controller branch from 2d39895 to 8cd8d67 Compare October 7, 2025 12:28
@cryptodev-2s cryptodev-2s force-pushed the cryptodev-2s/messenger/name-controller branch from 8cd8d67 to ecd695c Compare October 7, 2025 12:33
mcmire
mcmire previously approved these changes Oct 7, 2025
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 27, 2025
auto-merge was automatically disabled October 27, 2025 11:44

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 4a8975c Oct 27, 2025
256 of 257 checks passed
@FrederikBolding FrederikBolding deleted the cryptodev-2s/messenger/name-controller branch October 27, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants