Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Node.js versions 16, 21 #390

Merged
merged 2 commits into from
Oct 14, 2024
Merged

drop support for Node.js versions 16, 21 #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e48ded3
drop support for Node.js versions 16, 21
legobeat Oct 3, 2024
1ecad09
ci: modern node modules caching
legobeat Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 22 additions & 41 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,19 @@ jobs:
prepare:
name: Prepare
runs-on: ubuntu-latest
outputs:
YARN_CACHE_DIR: ${{ steps.yarn-cache-dir.outputs.YARN_CACHE_DIR }}
YARN_VERSION: ${{ steps.yarn-version.outputs.YARN_VERSION }}
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version:
- 18.x
- 20.x
- 22.x
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Get Yarn cache directory
run: echo "YARN_CACHE_DIR=$(yarn config get cacheFolder)" >> "$GITHUB_OUTPUT"
id: yarn-cache-dir
- name: Get Yarn version
run: echo "YARN_VERSION=$(yarn --version)" >> "$GITHUB_OUTPUT"
id: yarn-version
- name: Cache Yarn dependencies
uses: actions/cache@v3
with:
path: ${{ steps.yarn-cache-dir.outputs.YARN_CACHE_DIR }}
key: yarn-cache-${{ runner.os }}-${{ steps.yarn-version.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }}-${{ matrix.node-version }}
cache: 'yarn'
- name: Install Yarn dependencies
run: yarn --immutable
build:
Expand All @@ -41,18 +31,17 @@ jobs:
- prepare
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version:
- 18.x
- 20.x
- 22.x
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Restore Yarn dependencies
uses: actions/cache@v3
with:
path: ${{ needs.prepare.outputs.YARN_CACHE_DIR }}
key: yarn-cache-${{ runner.os }}-${{ needs.prepare.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }}-${{ matrix.node-version }}
cache: 'yarn'
- run: yarn --immutable
- run: yarn build
- name: Require clean working directory
Expand All @@ -67,20 +56,13 @@ jobs:
runs-on: ubuntu-latest
needs:
- prepare
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Restore Yarn dependencies
uses: actions/cache@v3
- name: Set up Node.js
uses: actions/setup-node@v4
with:
path: ${{ needs.prepare.outputs.YARN_CACHE_DIR }}
key: yarn-cache-${{ runner.os }}-${{ needs.prepare.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }}-${{ matrix.node-version }}
node-version-file: '.nvmrc'
cache: 'yarn'
- run: yarn --immutable
- run: yarn lint
- name: Validate RC changelog
Expand All @@ -103,18 +85,17 @@ jobs:
- prepare
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version:
- 18.x
- 20.x
- 22.x
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Restore Yarn dependencies
uses: actions/cache@v3
with:
path: ${{ needs.prepare.outputs.YARN_CACHE_DIR }}
key: yarn-cache-${{ runner.os }}-${{ needs.prepare.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }}-${{ matrix.node-version }}
cache: 'yarn'
- run: yarn --immutable
- run: yarn test
- name: Require clean working directory
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@metamask/eslint-config-nodejs": "^11.1.0",
"@metamask/eslint-config-typescript": "^11.1.0",
"@types/jest": "^27.0.6",
"@types/node": "^16.18.50",
"@types/node": "~18.18.14",
"@typescript-eslint/eslint-plugin": "^5.59.1",
"@typescript-eslint/parser": "^5.59.1",
"ajv": "^8.11.0",
Expand All @@ -80,7 +80,7 @@
},
"packageManager": "yarn@3.2.2",
"engines": {
"node": "^16.20 || ^18.16 || >=20"
"node": "^18.18 || ^20.14 || >=22"
},
"publishConfig": {
"access": "public",
Expand Down
26 changes: 14 additions & 12 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ __metadata:
"@metamask/utils": ^9.0.0
"@scure/base": ~1.1.3
"@types/jest": ^27.0.6
"@types/node": ^16.18.50
"@types/node": ~18.18.14
"@typescript-eslint/eslint-plugin": ^5.59.1
"@typescript-eslint/parser": ^5.59.1
ajv: ^8.11.0
Expand Down Expand Up @@ -1243,17 +1243,12 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:*":
version: 18.7.6
resolution: "@types/node@npm:18.7.6"
checksum: 5122988c325eda8d1f5cbe4494916036aae1758f9d5bb2d8139a800b8bad1540fbb167cd3c759da9a5cb4600cd3507609ac7969747113c1549a3e4320a17b1a9
languageName: node
linkType: hard

"@types/node@npm:^16.18.50":
version: 16.18.50
resolution: "@types/node@npm:16.18.50"
checksum: 8aec1eaf83407197ec2fe947182c238f49b82a7aace867cee1f81f72eb8a76c3c8b2adb1fd356e7443317cffb2546708da8934299a579edd25e3160bf7af30a1
"@types/node@npm:*, @types/node@npm:~18.18.14":
version: 18.18.14
resolution: "@types/node@npm:18.18.14"
dependencies:
undici-types: ~5.26.4
checksum: 3a77e6819e50fd22196b08d542433e1513c855f4993a200bc0e7be076445c61ce2a9e5f7f202f060c46130b2b2f98643461fb7999f874475e6bb322c4534c580
languageName: node
linkType: hard

Expand Down Expand Up @@ -5904,6 +5899,13 @@ __metadata:
languageName: node
linkType: hard

"undici-types@npm:~5.26.4":
version: 5.26.5
resolution: "undici-types@npm:5.26.5"
checksum: 3192ef6f3fd5df652f2dc1cd782b49d6ff14dc98e5dced492aa8a8c65425227da5da6aafe22523c67f035a272c599bb89cfe803c1db6311e44bed3042fc25487
languageName: node
linkType: hard

"unique-filename@npm:^1.1.1":
version: 1.1.1
resolution: "unique-filename@npm:1.1.1"
Expand Down
Loading