Skip to content

Commit

Permalink
chore: bump @metamask/base-controller to ^7.0.0 (#27032)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR bumps @metamask/base-controller to v7.0.0.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27032?quickstart=1)

## **Related issues**

Fixes: #26920 

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
  • Loading branch information
4 people authored Sep 11, 2024
1 parent b960add commit 3797b2f
Show file tree
Hide file tree
Showing 8 changed files with 964 additions and 195 deletions.
1 change: 0 additions & 1 deletion app/scripts/lib/snap-keyring/utils/isBlockedUrl.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ describe('isBlockedUrl', () => {
allowedEvents: [],
});
const phishingController = new PhishingController({
// @ts-expect-error TODO: Resolve mismatch between base-controller versions.
messenger: phishingControllerMessenger,
state: {
phishingLists: [
Expand Down
2 changes: 2 additions & 0 deletions app/scripts/lib/transaction/smart-transactions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ function withRequest<ReturnValue>(
});

const smartTransactionsController = new SmartTransactionsController({
// @ts-expect-error TODO: Resolve mismatch between base-controller versions.
messenger,
getNonceLock: jest.fn(),
confirmExternalTransaction: jest.fn(),
Expand Down Expand Up @@ -176,6 +177,7 @@ function withRequest<ReturnValue>(

return fn({
request,
// @ts-expect-error TODO: Resolve mismatch between base-controller versions.
messenger,
startFlowSpy,
addRequestSpy,
Expand Down
Loading

0 comments on commit 3797b2f

Please sign in to comment.