Skip to content

Commit

Permalink
use popup.html directly in firefox
Browse files Browse the repository at this point in the history
Firefox is very slow to render the `popup-init.html` redirect, and it renders the page only partially anyway, making the UX feel very janky. It also doesn't delay opening the popup until `DOMContentLoaded`, like chrome does, so the issue `popup-init.html` solves doesn't do anything anyway.
  • Loading branch information
davidmurdoch committed Aug 27, 2024
1 parent fcf6a91 commit 83f0c20
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
16 changes: 15 additions & 1 deletion app/manifest/v2/firefox.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,19 @@
"id": "webextension@metamask.io",
"strict_min_version": "89.0"
}
}
},
"browser_action": {
"default_icon": {
"16": "images/icon-16.png",
"19": "images/icon-19.png",
"32": "images/icon-32.png",
"38": "images/icon-38.png",
"64": "images/icon-64.png",
"128": "images/icon-128.png",
"512": "images/icon-512.png"
},
"default_title": "MetaMask",
"default_popup": "popup-init.html"
},
"manifest_version": 2
}
2 changes: 1 addition & 1 deletion app/manifest/v3/firefox.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"512": "images/icon-512.png"
},
"default_title": "MetaMask",
"default_popup": "popup-init.html"
"default_popup": "popup.html"
},
"manifest_version": 2
}

0 comments on commit 83f0c20

Please sign in to comment.