-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
…tion dialog (#28270) ## **Description** Adds a "Add a new Solana account" link to the account creation dialog: ## **Related issues** Fixes: [[SOL-24] [Setup] Add "Add a new Solana account (Beta)" button to the account picker](https://consensyssoftware.atlassian.net/browse/SOL-24?atlOrigin=eyJpIjoiYzhmNjk2NzVmZWM1NDFhNmI5NWZhMjc3YjkzM2I3OTIiLCJwIjoiaiJ9) ## **Manual testing steps** 1. Build and load the extension locally 2. Open the account picker 3. Click on "Add account or hardware wallet" 4. Click on "Add a new Solana wallet (Beta)" 5. A new Solana wallet should have been created, using the same seed phrase used for Ethereum accounts ## **Screenshots/Recordings** ![Screenshot 2024-11-07 at 13 59 22](https://github.com/user-attachments/assets/15c51041-26ea-4ba4-b987-aed9ae57c277) ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [SOL-24]: https://consensyssoftware.atlassian.net/browse/SOL-24?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net> Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com> Co-authored-by: António Regadas <apregadas@gmail.com> Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.