Skip to content

Commit e1444c9

Browse files
authored
feat: add solana to beta (#30613)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Moving solana code fences to `beta` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30613?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent ebc6f30 commit e1444c9

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

app/scripts/metamask-controller.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,7 @@ const environmentMappingForRemoteFeatureFlag = {
413413
const buildTypeMappingForRemoteFeatureFlag = {
414414
flask: DistributionType.Flask,
415415
main: DistributionType.Main,
416+
beta: 'beta',
416417
};
417418

418419
export default class MetamaskController extends EventEmitter {

app/scripts/metamask-controller.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4204,7 +4204,7 @@ describe('MetaMaskController', () => {
42044204
});
42054205

42064206
it('returna config when not matching default mapping', async () => {
4207-
process.env.METAMASK_BUILD_TYPE = 'beta';
4207+
process.env.METAMASK_BUILD_TYPE = 'non-existent-distribution';
42084208
process.env.METAMASK_ENVIRONMENT = ENVIRONMENT.RELEASE_CANDIDATE;
42094209

42104210
const result =

builds.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ buildTypes:
4040
features:
4141
- build-beta
4242
- keyring-snaps
43+
- multichain
44+
- solana
45+
- solana-swaps
4346
env:
4447
- INFURA_BETA_PROJECT_ID
4548
- SEGMENT_BETA_WRITE_KEY

test/e2e/snaps/test-snap-uilinks.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ describe('Test Snap UI Links', function () {
112112

113113
// check that the correct page has been opened
114114
await driver.waitForSelector({
115-
text: 'Most Popular',
115+
text: 'Most popular',
116116
tag: 'h2',
117117
});
118118

0 commit comments

Comments
 (0)