Only display interacting with for token transfers within advanced view when simulations is unavailable #28309
Assignees
Labels
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-confirmations
Push issues to confirmations team
type-enhancement
Comments
bschorchit
added
type-enhancement
team-confirmations
bschorchit
changed the title
pedronfigueiredo
changed the title
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 14, 2024
…#28409) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The "Interacting with" section is shown only if the simulated changes are empty, if there was a simulation error or if the advanced details view is toggled on. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/28409?quickstart=1) ## **Related issues** Fixes: [#28309](#28309) ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/28409?quickstart=1){kind=link}
metamaskbot
added
the
release-12.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
For token transfer transactions on the redesigned confirmations & when the
Estimated changesare available, we should hide theInteracting withrow behind advanced view to avoid repetitive information.Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: