[POM] Migrate vault decryption e2e tests to TS and Page Object Model #28431
Assignees
Labels
area-qa
Relating to QA work (Quality Assurance)
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-extension-platform
Comments
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 15, 2024
…Model (#28419) ## **Description** - Migrate e2e tests `test/e2e/vault-decryption-chrome.spec.js` to TS and Page Object Model, this test runs only on develop branch, by migrating to POM, we improve the maintainability. - Create page classe functions for vault decryption page, so we can use that in the future when needed - Deprecate/remove old functions in `helper.js` - Improved testing logs to make it easier to debug. See testing logs on this branch:  [](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1) ## **Related issues** Fixes: #28431 ## **Manual testing steps** Check code readability, make sure tests pass. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: seaona <54408225+seaona@users.noreply.github.com>
](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1){kind=link}
metamaskbot
added
the
release-12.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Migrate vault decryption e2e tests to TS and Page Object Model, this test runs only on develop branch, by migrating to POM, we improve the maintenance.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: