Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable account syncing on extension #28438

Closed
mathieuartu opened this issue Nov 13, 2024 · 0 comments · Fixed by #28596
Closed

Enable account syncing on extension #28438

mathieuartu opened this issue Nov 13, 2024 · 0 comments · Fixed by #28596
Assignees
@mathieuartu
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-identity

Comments

@mathieuartu
Copy link
Contributor

No description provided.

@mathieuartu mathieuartu self-assigned this Nov 13, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Nov 13, 2024
@mathieuartu mathieuartu mentioned this issue Nov 21, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 26, 2024
@mathieuartu
feat: enable account syncing in production (#28596)
fd3ac16 
## **Description**

This PR enables account syncing in production

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28596?quickstart=1)

## **Related issues**

Fixes: #28438 

## **Manual testing steps**

1. Onboard with your SRP
2. Add accounts, rename accounts
3. Uninstall the extension
4. Reinstall and onboard with the previous SRP
5. Verify that your added & renamed accounts are there

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathieuartu mathieuartu

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable account syncing in production MetaMask/metamask-extension
2 participants
@mathieuartu @metamaskbot