-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Initiating a swap from the "All networks" assets view for a token on a different network than the one currently selected results in the token balance being displayed as zero on the swap screen #28509
Comments
Addressed here: 0235189 |
@gambinish @jonybur insufficientBalance.mov |
Issue is not present in the qa-3 build. The balance of the token seems to be updated correctly on the swap screen. Swap.from.other.network.than.the.one.selected.mov |
I'm about to release another build |
@gambinish 1.mov |
Confirming same bahavior in qa 5- build: After destination token is selected, the message disappears: Screen.Recording.2024-11-21.at.12.56.59.mov |
Thanks, this sounds like a messaging issue that should be a quick fix. Likely still in qa-6, but I can look at fixing this tomorrow |
The 'Not enough token' message is not related to the fact that user selects the token on a different network. Screen.Recording.2024-11-23.at.00.45.35.mov |
Reproduced on qa-7 build, when swapping non native tokens from the token details screen. The message disappears after selecting the token to swap to Swap.from.token.details.screen.mov |
This PR should address this issue: #28707 will try to include in the qa-8 build |
Not present in qa-8 build: Swap.non-native.from.token.details.screen.mov |
Closing, since this seems to be fixed on qa-8 |
## **Description** Decimal balance are needed to be passed along with the rest of the token info in order to properly prepopulate the swaps UI. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28707?quickstart=1) ## **Related issues** Fixes: #28509 ## **Manual testing steps** 1. Navigate from AssetList to TokenDetails to Swap UI 2. Populate text field with a balance amount 3. If balance is lower than the token balance, do not show the warning. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Describe the bug
Attempting to initiate a swap from the "All networks" assets view for a token on a different network than the one currently selected results in the token balance being displayed as zero. Transaction can't be submitted.
Build https://drive.google.com/file/d/1qhGX0lnrTX47M_7kbqBmhOXTd8HvmflL/view?usp=drive_link
Expected behavior
Screenshots/Recordings
swapTokenBalance.mov
Steps to reproduce
Error messages or log output
No response
Detection stage
On the development branch
Version
dev build
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: