[Bug]: The "Select an account" modal displays incorrect balances #28592
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-assets
type-bug
Comments
sleepytanya
added
type-bug
team-assets
portfolio-view
|
Present in qa-5 build in "Select Account" mode and also "Send" flow:
|
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 21, 2024
## **Description** Fixes account list item wit Portfolio view feature flag. [](https://codespaces.new/MetaMask/metamask-extension/pull/28598?quickstart=1) ## **Related issues** Fixes: #28592 ## **Manual testing steps** Make sure you run the steps with AND without the PORTFOLIO_VIEW flag 1. Go to settings => Security and privacy => and disable "Show balance and token price checker" 2. Open account picker make sure you see crypto values 3. Enable the setting again and you should see Fiat values ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/28598?quickstart=1){kind=link}
metamaskbot
added
the
release-12.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The "Select an account" modal displays incorrect balances. Balances vary depending on the currently selected network but the balance is always incorrect (too big).
For a newly added account the correct balance is shown - 0.
qa-5 build
Expected behavior
Screenshots/Recordings
balance.mov
Steps to reproduce
Error messages or log output
No response
Detection stage
On the development branch
Version
qa-5 build
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: