Fix "Settings - general tab @no-mmi validate \"Deutsch\" ..." flaky tests #28698
Assignees
Labels
flaky tests
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-extension-platform
type-bug
Comments
hjetpoluru
added
type-bug
Sev2-normal
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 29, 2024
… Object Model (#28777) ## **Description** - Fix change language flaky tests. There are multiple reasons for the flakiness, including taking actions during the loading spinner and excessive misuse of refresh page - Migrate change language e2e tests to Page Object Model - Created base pages for advanced settings page and general settings page - For some special language-related locators, as they are only used in this specific test, I didn't migrate them to POM methods. [](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1) ## **Related issues** Fixes:#27904 #28698 #27390 ## **Manual testing steps** Check code readability, make sure tests pass. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1){kind=link}
|
Fixed by PR #28777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/112248/workflows/04cbc7b8-7ece-4dd0-a143-5412d04b57f8/jobs/4203278/tests
test-e2e-chrome-webpack
Test scenario - Settings - general tab @no-mmi validate "Deutsch" language on error messages
Test path - /test/e2e/tests/settings/change-language.spec.ts
The text was updated successfully, but these errors were encountered: