Extension: Portfolio View: Update activity list copy on Token Details #28766
Assignees
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
release-12.9.0
Issue or pull request that will be included in release 12.9.0
team-assets
Comments
hesterbruikman
added
the
portfolio-view
7 tasks
Open
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 27, 2024
fixes #28766 <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** If the token chosen in the token details does not correspond to the current network, the message displayed in the activity section should be updated accordingly. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/28764?quickstart=1) ## **Related issues** Fixes: #28766 ## **Manual testing steps** 1. run `PORTFOLIO_VIEW=true yarn start` 2. choose any token who is not part of current network and go to token details 3. go to activity section and check the message ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/e0d379b8-dd37-4e87-a845-ff35a08deb76 <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/28764?quickstart=1){kind=link}
metamaskbot
added
the
release-12.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Update copy on Token Details when a token is shown for a network that the user is not currently on. The current copy can be confusing because it states that there are no transactions, while the user might have transactions for this token, but they are not visible because they are on a different network. This issue is temporary as cross-chain activity polling is planned.
Current copy
You have no transactionsExpected copy
Please switch to [network] to view transactionsScenario
WHEN All networks is enabled
AND Tapping on a token on a network other than the Globally Selected Network
THEN The Activity list on token details shows
You have no transactions>>>Please switch to [network] to view transactionsDesign
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: