Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sneaky little fox, appropriate logo,lol. cant get ether back to my desktop wallet #2877

Closed
heybud1 opened this issue Jan 6, 2018 · 5 comments

Comments

@heybud1
Copy link

heybud1 commented Jan 6, 2018

Im glad I only put 20 dollars of ether into metamask trying to learn the exchange. Cant deposit into etherdelta smart contract so tried to to go back to desktop wallet and cant get a transaction address or anything. Even if i increase the gas to 40% of transction. I guess my trades will stay on other exchanges.

@heybud1
Copy link
Author

heybud1 commented Jan 6, 2018

all i received were some defensive emails but no useful feedback

@tmashuang
Copy link
Contributor

tmashuang commented Jan 6, 2018

Seems this and #2876 are your "issues" you are referring to. I will try to clarify to the best of my ability with the fragmented information provided on the possible issue with transactions via EtherDelta. We allow Dapps to submit transactions with what they determine an adequate gas price would be. Dapps can guess the appropriate gas price or just submit a default one. In EtherDelta's case they submit a default of 4 Gwei. The recommended gas price can be found on EthGasStation. To prevent transactions being stuck in limbo when there is an abundance of transactions, we prevent sending transactions that are not close to the recommended gas price. Network congestion can be seen here, https://etherscan.io/txsPending. We could handle the transaction state better. The resolution would be to send a transaction with the recommended gas price. 40% of 4 is still a low gas price in times when there's an abundance of transactions trying to get processed.

@heybud1
Copy link
Author

heybud1 commented Jan 6, 2018

pretty funny only took a couple seconds to put my .02 ether and been trying to get it out for 6 hours. A little help would be appreciated. Thanks I tried to paying almost half in gas of my .02 ether and still can't withdraw .014. obviously I'm missing something. also tried exporting still can't.

@heybud1
Copy link
Author

heybud1 commented Jan 6, 2018

why would I want to deposit real money in this wallet when there are wallets on exchanges that will help me

@heybud1
Copy link
Author

heybud1 commented Jan 6, 2018

40% of 20$ is 8$. that is absurd and still can't

github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Adds test for checking transaction decoding for contract interaction
from 4bytes, sourcify and uniswap
Also adds tests to verify when all of the above fails then it falls back
to the raw hexdata
Adds a data-testId to make e2e easier

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28204?quickstart=1)

## **Related issues**

Fixes:
[#2877](MetaMask/MetaMask-planning#2877)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants