feat: add option of copy to info row component #25682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
confirmation-redesign
team-confirmations
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [90b949f]
Page Load Metrics (68 ± 10 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25682 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 1390 1391 +1
Lines 48895 48905 +10
Branches 13451 13456 +5
========================================
+ Hits 34207 34216 +9
- Misses 14688 14689 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [54a405c]
Page Load Metrics (270 ± 252 ms)
Bundle size diffs
|
| <ConfirmInfoRow label={t('advancedDetailsHexDesc')}> | ||
| <ConfirmInfoRow | ||
| label={t('advancedDetailsHexDesc')} | ||
| copyEnabled |
Member
There was a problem hiding this comment.
Can we now delete the copy button below?
Contributor
Author
There was a problem hiding this comment.
Button here is like copy link Copy raw transaction data you see in this image:
Member
There was a problem hiding this comment.
Exactly, my understanding was they do the same thing, so we are switching to just the copy icon on the row itself?
Contributor
Author
There was a problem hiding this comment.
I see, I removed that copy option now.
Collaborator
Builds ready [9d22922]
Page Load Metrics (186 ± 237 ms)
Bundle size diffs
|
matthewwalsh0
requested changes
Jul 11, 2024
| <ConfirmInfoRow label={t('advancedDetailsHexDesc')}> | ||
| <ConfirmInfoRow | ||
| label={t('advancedDetailsHexDesc')} | ||
| copyEnabled |
Member
There was a problem hiding this comment.
Exactly, my understanding was they do the same thing, so we are switching to just the copy icon on the row itself?
|
Collaborator
Builds ready [49701b4]
Page Load Metrics (340 ± 404 ms)
Bundle size diffs
|
matthewwalsh0
approved these changes
Jul 12, 2024
Member
matthewwalsh0
left a comment
matthewwalsh0
left a comment
There was a problem hiding this comment.
My understanding is we've not enabled this on the data row in this PR, but that can be done in a subsequent one.
pedronfigueiredo
approved these changes
Jul 15, 2024
metamaskbot
added
the
release-12.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option of copy to info row component
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2743
Manual testing steps
CopyEnabledstory inInfoRowcomponentScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist