feat: add utility function to get supported chains from the Security Alerts API #25716

vinistevam · 2024-07-09T09:48:53Z

Description

This PR aims to include a new utility function to get supported chains from the Security Alerts API when enabled.

Related Repository

Refer to the Security Alerts API repository for more details.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2846

Manual testing steps

Test blockaid regression
add the envs

SECURITY_ALERTS_API_URL='https://security-alerts.dev-api.cx.metamask.io'
SECURITY_ALERTS_API_ENABLED='true'

Go to test dapp and trigger on of the malicious signatures
To verify in chrome go to dev tools > network. Search for security-alerts and find the call to the API service.

Existing PPOM logic should function as before, even with the above environment variables added, due to the fallback to the controller in the event of an error.

Screenshots/Recordings

supported-chains.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-09T09:49:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-07-10T13:05:47Z

Builds ready [7e6af5d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (208 ± 230 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	392	140	62	30
		domContentLoaded	13	46	31	10	5
		load	60	2286	208	479	230
		domInteractive	13	46	31	10	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 451 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-07-10T13:05:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (3454333) to head (fe04f80).
Report is 9 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25716   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1400     1400           
  Lines        49513    49521    +8     
  Branches     13692    13693    +1     
========================================
+ Hits         34495    34502    +7     
- Misses       15018    15019    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/scripts/lib/ppom/security-alerts-api.ts

app/scripts/lib/ppom/ppom-middleware.ts

metamaskbot · 2024-07-11T12:28:21Z

Builds ready [47cce73]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (152 ± 141 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	378	121	76	36
		domContentLoaded	9	79	29	19	9
		load	39	1406	152	293	141
		domInteractive	9	79	29	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 338 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: -271 Bytes (-0.00%)

app/scripts/lib/transaction/util.ts

metamaskbot · 2024-07-16T13:36:31Z

Builds ready [5bfc335]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (76 ± 10 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	134	102	19	9
		domContentLoaded	9	64	32	17	8
		load	43	112	76	22	10
		domInteractive	9	64	32	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 344 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: -271 Bytes (-0.00%)

sonarqubecloud · 2024-07-19T12:04:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-19T12:54:07Z

Builds ready [fe04f80]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (162 ± 186 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	80	130	101	16	7
		domContentLoaded	10	64	25	11	6
		load	42	1853	162	388	186
		domInteractive	10	64	25	11	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 344 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: -278 Bytes (-0.00%)

vinistevam added 2 commits July 9, 2024 10:05

feat: add supported chains utils

15ee63e

use security alert api to check supported chains

57b128a

vinistevam added the team-confirmations Push issues to confirmations team label Jul 9, 2024

fix chain supported usage

3bd6e85

vinistevam marked this pull request as ready for review July 9, 2024 12:57

vinistevam requested a review from a team as a code owner July 9, 2024 12:57

vinistevam and others added 3 commits July 9, 2024 13:58

Merge branch 'develop' into feat/add-utility-function-supported-chains

2c43919

fix unit test

d1047bd

add fallback in case api is not available

7e6af5d

pedronfigueiredo previously approved these changes Jul 10, 2024

View reviewed changes

jpuri previously approved these changes Jul 10, 2024

View reviewed changes

matthewwalsh0 requested changes Jul 10, 2024

View reviewed changes

app/scripts/lib/ppom/security-alerts-api.ts Outdated Show resolved Hide resolved

app/scripts/lib/ppom/ppom-middleware.ts Show resolved Hide resolved

vinistevam added 3 commits July 11, 2024 11:54

apply suggestions

36c4290

Merge branch 'develop' into feat/add-utility-function-supported-chains

3f526f8

update supported chains in transaction utils

47cce73

vinistevam dismissed stale reviews from jpuri and pedronfigueiredo via 47cce73 July 11, 2024 11:46

matthewwalsh0 requested changes Jul 12, 2024

View reviewed changes

app/scripts/lib/transaction/util.ts Outdated Show resolved Hide resolved

revert await validateRequestWithPPOM

5bfc335

matthewwalsh0 approved these changes Jul 17, 2024

View reviewed changes

Merge branch 'develop' into feat/add-utility-function-supported-chains

fe04f80

jpuri approved these changes Jul 22, 2024

View reviewed changes

OGPoyraz approved these changes Jul 22, 2024

View reviewed changes

vinistevam merged commit 2103232 into develop Jul 22, 2024
82 checks passed

vinistevam deleted the feat/add-utility-function-supported-chains branch July 22, 2024 10:36

github-actions bot locked and limited conversation to collaborators Jul 22, 2024

metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add utility function to get supported chains from the Security Alerts API #25716

feat: add utility function to get supported chains from the Security Alerts API #25716

vinistevam commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 9, 2024

metamaskbot commented Jul 10, 2024

codecov bot commented Jul 10, 2024 •

edited

Loading

metamaskbot commented Jul 11, 2024

metamaskbot commented Jul 16, 2024

sonarqubecloud bot commented Jul 19, 2024

metamaskbot commented Jul 19, 2024

feat: add utility function to get supported chains from the Security Alerts API #25716

feat: add utility function to get supported chains from the Security Alerts API #25716

Conversation

vinistevam commented Jul 9, 2024 • edited Loading

Description

Related Repository

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 9, 2024

metamaskbot commented Jul 10, 2024

codecov bot commented Jul 10, 2024 • edited Loading

Codecov Report

metamaskbot commented Jul 11, 2024

metamaskbot commented Jul 16, 2024

sonarqubecloud bot commented Jul 19, 2024

Quality Gate passed

metamaskbot commented Jul 19, 2024

vinistevam commented Jul 9, 2024 •

edited

Loading

codecov bot commented Jul 10, 2024 •

edited

Loading