Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Near Icon #26459

Merged
merged 1 commit into from
Aug 16, 2024
Merged

chore: Add Near Icon #26459

merged 1 commit into from
Aug 16, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Aug 16, 2024

Description

Adds NEAR Icon for ChainId 397 and 398. These chains are currently new networks being integrated onto EVM. They are currently in development, but it was requested from their team to preemptively add these icons, before production RPC endpoints are available.

For context, here is their proposal: near/NEPs#518

https://chainlist.org/chain/397
https://chainlist.org/chain/398

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-343

Manual testing steps

Once production RPCs are available, these icons should appear when NEAR RPC gets added in custom networks.

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Aug 16, 2024

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (2dc3768) to head (d6efa7f).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26459   +/-   ##
========================================
  Coverage    70.11%   70.12%           
========================================
  Files         1428     1428           
  Lines        50089    50090    +1     
  Branches     13894    13894           
========================================
+ Hits         35119    35121    +2     
+ Misses       14970    14969    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [d6efa7f]
Page Load Metrics (147 ± 173 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7414194189
domContentLoaded96823136
load461712147359173
domInteractive96823136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 155 Bytes (0.00%)

@gambinish gambinish marked this pull request as ready for review August 16, 2024 16:40
@gambinish gambinish requested a review from a team as a code owner August 16, 2024 16:40
@gambinish gambinish merged commit 3c066c5 into develop Aug 16, 2024
83 of 84 checks passed
@gambinish gambinish deleted the chore/mmassets-343_update-near-icon branch August 16, 2024 22:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 16, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants