Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Reintegrate refactored Swap e2e tests to the pipeline #26493

Merged
merged 23 commits into from
Nov 12, 2024
Merged

test: Reintegrate refactored Swap e2e tests to the pipeline #26493

merged 23 commits into from
Nov 12, 2024

Conversation

davibroc
Copy link
Contributor

@davibroc davibroc commented Aug 19, 2024 •
edited
Loading

Description

The new extension e2e test automation includes the following test scenarios after the code refactoring.

✓ 1 should swap native token ETH to DAI on Tenderly - Mainnet' (41.2s)
✓ 2 should swap unapproved token DAI to ETH on Tenderly - Mainnet' (48.2s)
✓ 3 should swap native token ETH to WETH on Tenderly - Mainnet' (39.0s)
✓ 4 should swap wrapped token WETH to ETH on Tenderly - Mainnet' (38.8s)
✓ 5 should swap ERC20->ERC20 token DAI to USDC on Tenderly - Mainnet' (41.0s)

Highlights:

  • re-enabled the script to run in the github pipeline as optional
  • removed flakiness
  • switched to Tenderly corporate account as previously we were using my personal
  • added swap of unapproved token
  • added swap of ERC20->ERC20 (DAI to USDC)

Related issues

Fixes:

Manual testing steps

  1. yarn playwright install chromium
  2. yarn
  3. yarn dist
  4. yarn test:e2e:swap

Screenshots/Recordings

e2e_extension.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@davibroc davibroc requested a review from a team as a code owner August 19, 2024 12:34
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davibroc davibroc requested review from kumavis and a team as code owners August 22, 2024 17:02
@davibroc davibroc changed the title Test/fix swap e2e tests test: Swap e2e tests improvements Aug 22, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [33a635f]
Page Load Metrics (85 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811541152110
domContentLoaded44130812311
load51130852010
domInteractive9472694
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [d8f0e8f]
Page Load Metrics (76 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint77151102199
domContentLoaded4410571189
load5010576188
domInteractive85828136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [e288993]
Page Load Metrics (99 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint714971318742
domContentLoaded42396967234
load49396997034
domInteractive10187393718
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (1b22343) to head (e288993).
Report is 90 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26493      +/-   ##
===========================================
- Coverage    70.19%   70.09%   -0.10%     
===========================================
  Files         1420     1413       -7     
  Lines        49769    49255     -514     
  Branches     13828    13768      -60     
===========================================
- Hits         34933    34524     -409     
+ Misses       14836    14731     -105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e288993]
Page Load Metrics (88 ± 13 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint791791182914
domContentLoaded50132842813
load54146882813
domInteractive176933136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [e288993]
Page Load Metrics (80 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint593651106330
domContentLoaded46277764923
load46277804723
domInteractive97528168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [cdda382]
Page Load Metrics (1632 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19124331443552265
domContentLoaded142723311614213102
load143023621632217104
domInteractive137837168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [d870874]
Page Load Metrics (1879 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37422851803379182
domContentLoaded16012228184617082
load16102287187917986
domInteractive18168463115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [d870874]
Page Load Metrics (1766 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34926801706388187
domContentLoaded150526691741237114
load154926781766235113
domInteractive14138412813
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [d870874]
Page Load Metrics (1731 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38420031645318153
domContentLoaded14952074170715273
load15032078173115374
domInteractive13170473617
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [d870874]
Page Load Metrics (1975 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21922331802545262
domContentLoaded16892172194414871
load16952244197515775
domInteractive178441199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [3c1229a]
Page Load Metrics (1953 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16252220194916177
domContentLoaded16162187191115072
load16242291195316278
domInteractive16180443617
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [5c2fef9]
Page Load Metrics (1822 ± 160 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24330821731472227
domContentLoaded154529861790314151
load157030771822334160
domInteractive15198483919
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5c2fef9]
Page Load Metrics (1927 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24021961838393189
domContentLoaded15542178189514569
load15642211192715273
domInteractive158239167
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5c2fef9]
Page Load Metrics (1779 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16032235178914570
domContentLoaded15962171175113163
load16042241177914368
domInteractive137841168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5c2fef9]
Page Load Metrics (2033 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27124311948441212
domContentLoaded167424251995222107
load171724312033219105
domInteractive2710945189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5c2fef9]
Page Load Metrics (1870 ± 117 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33026741784413198
domContentLoaded162626231844237114
load163426681870243117
domInteractive148740199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f08c4a8]
Page Load Metrics (1761 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1638205417598340
domContentLoaded1625199517357938
load1631205217618742
domInteractive17190453718
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f08c4a8]
Page Load Metrics (1749 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint143425701756299144
domContentLoaded139124571717274132
load143025781749292140
domInteractive13167403316
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [3b28b3e]
Page Load Metrics (2103 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17052403210716479
domContentLoaded16932389207816680
load17072405210316881
domInteractive19185634320
backgroundConnect125521105
firstReactRender482681154622
getState572302512
initialActions01000
loadScripts12431891153715675
setupStore1370292110
uiStartup190329382355217104
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davibroc davibroc changed the title test: Swap e2e tests improvements test: Reintegrate the Swap e2e tests to the pipeline Oct 31, 2024
@davibroc davibroc changed the title test: Reintegrate the Swap e2e tests to the pipeline test: Reintegrate refactored Swap e2e tests to the pipeline Oct 31, 2024
Gudahtt
Gudahtt requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to fix CI config error

Gudahtt
Gudahtt approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - CircleCI config changes look good to me, I am approving those for the library-admins team.

@davibroc davibroc added this pull request to the merge queue Nov 12, 2024
Merged via the queue into develop with commit a45b674 Nov 12, 2024
89 checks passed
@davibroc davibroc deleted the test/fix-swap-e2e-tests branch November 12, 2024 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chloeYue chloeYue chloeYue approved these changes

@martahj martahj martahj approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

Assignees
No one assigned
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-swaps
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davibroc @metamaskbot @Gudahtt @martahj @chloeYue