-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused swaps code #27679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
martahj
force-pushed
the
remove-unused-code
branch
from
October 7, 2024 19:43
4deb4c0
to
63f92f0
Compare
martahj
force-pushed
the
remove-unused-code
branch
from
October 8, 2024 15:21
8117c4e
to
5328384
Compare
Builds ready [5328384]
Page Load Metrics (2221 ± 141 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
ejwessel
approved these changes
Oct 8, 2024
infiniteflower
approved these changes
Oct 9, 2024
jclancy93
approved these changes
Oct 11, 2024
NidhiKJha
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
darkwing
approved these changes
Oct 11, 2024
Builds ready [fda3ee0]
Page Load Metrics (1788 ± 77 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2024
Builds ready [a8e6bd9]
Page Load Metrics (2112 ± 148 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2024
davibroc
force-pushed
the
remove-unused-code
branch
from
October 12, 2024 00:55
a8e6bd9
to
81d8db1
Compare
Quality Gate failedFailed conditions |
Builds ready [81d8db1]
Page Load Metrics (1850 ± 64 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 15, 2024
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 15, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.7.0
Issue or pull request that will be included in release 12.7.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed code which is no longer needed because we are moving forward with the swaps redesign.
Manual testing steps
Test Swaps flows and confirm no regresions.
Pre-merge author checklist
Pre-merge reviewer checklist