Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain: Lint #27745

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Multichain: Lint #27745

merged 3 commits into from
Oct 9, 2024

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Oct 9, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@json-schema-tools/traverse@1.10.4 None 0 26.4 kB belfordz

🚮 Removed packages: npm/@json-schema-tools/traverse@1.10.3

View full report↗︎

@jiexi jiexi changed the title Jl/caip multichain/lint Multichain: Lint Oct 9, 2024
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@jiexi jiexi marked this pull request as ready for review October 9, 2024 22:46
@jiexi jiexi requested a review from a team as a code owner October 9, 2024 22:46
@jiexi jiexi merged commit 6c3bc39 into caip-multichain Oct 9, 2024
65 of 73 checks passed
@jiexi jiexi deleted the jl/caip-multichain/lint branch October 9, 2024 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants