Multichain: Do not add permittedChain scope for snaps. Use new networkConfigurationsByChainId property #27849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jiexi
changed the title
|
Should revisit if we really need to set accounts on |
shanejonas
approved these changes
Oct 15, 2024
…mittedChains-for-snaps
adonesky1
reviewed
Oct 15, 2024
| @@ -547,6 +655,14 @@ describe('migration #131', () => { | |||
| methods: [], | |||
| notifications: [], | |||
| }, | |||
| 'wallet:eip155': { | |||
| accounts: [ | |||
| 'wallet:eip155:0xdeadbeef', | |||
There was a problem hiding this comment.
I feel like this is a good illustration of why having CAIP-10 addresses in this array is silly. 🤷
jiexi
deleted the
jl/caip-multichain/do-not-add-permittedChains-for-snaps
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist