Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent scrolling to account list item on send page #27934

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

bfullam
Copy link
Contributor

@bfullam bfullam commented Oct 17, 2024

Description

Opening the send page scrolls down to the currently selected account. On a wallet with 6+ accounts, this scrolls so far that the more relevant sending UI is out of view. This PR prevents the scrolling behavior, keeping the relevant UI in view.

Open in GitHub Codespaces

Manual testing steps

  1. On a wallet with 6+ addresses, select the last address on extension
  2. Click the Send button

Screenshots/Recordings

Before

Screenshot 2024-10-17 at 17 15 19

After

Screenshot 2024-10-17 at 17 16 05

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bfullam bfullam marked this pull request as ready for review October 17, 2024 16:48
@bfullam bfullam requested a review from a team as a code owner October 17, 2024 16:48
@metamaskbot
Copy link
Collaborator

Builds ready [c5ecec3]
Page Load Metrics (1826 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17192353184314971
domContentLoaded1658208417899144
load17132108182611455
domInteractive1487502211
backgroundConnect8203404923
firstReactRender47155922612
getState4215284723
initialActions01000
loadScripts1230150413277235
setupStore11128353215
uiStartup185928582084240115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 109 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [4354f70]
Page Load Metrics (1917 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43226351840396190
domContentLoaded160225511877220106
load161625961917230110
domInteractive13107592311
backgroundConnect1086462211
firstReactRender492961115225
getState688222512
initialActions01000
loadScripts114020591388209100
setupStore15103372914
uiStartup180628162164270130
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 109 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f595e59]
Page Load Metrics (2133 ± 262 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47844092057651312
domContentLoaded174337692053415199
load175544152133547262
domInteractive28156583215
backgroundConnect77488416278
firstReactRender492081074019
getState6167243919
initialActions00000
loadScripts128223051505222106
setupStore11127483416
uiStartup196146012412591284
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 111 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bfullam bfullam added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@bfullam bfullam added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@bfullam bfullam added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@bfullam bfullam added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@bfullam bfullam added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 22, 2024
@bfullam bfullam added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit 80cfcf7 Oct 22, 2024
76 checks passed
@bfullam bfullam deleted the MMS-1589-fix-scroll-on-send-page branch October 22, 2024 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants