Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore warning for ethereumjs-wallet #28145

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 29, 2024

Description

To unblock develop, creating this PR that adds ethereumjs-wallet to list of deprecated packages that are ignored when using yarn audit. .

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner October 29, 2024 10:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3368b7b]
Page Load Metrics (1968 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32125641818516248
domContentLoaded17292408194216780
load17432422196817282
domInteractive16118542612
backgroundConnect95627168
firstReactRender574001368641
getState66317178
initialActions01000
loadScripts12651803144914268
setupStore1298372813
uiStartup196031172266316152
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit 3a35385 Oct 29, 2024
86 checks passed
@sahar-fehri sahar-fehri deleted the chore/add-ethereumjs-wallet-to-deprecated-list branch October 29, 2024 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@metamaskbot metamaskbot added release-12.7.0 Issue or pull request that will be included in release 12.7.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.6.0 on PR. Adding release label release-12.6.0 on PR and removing other release labels(release-12.7.0), as PR was cherry-picked in branch 12.6.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants