test: add e2e for transaction decoding #28204

pnarayanaswamy · 2024-10-31T10:18:40Z

Description

Adds test for checking transaction decoding for contract interaction from 4bytes, sourcify and uniswap
Also adds tests to verify when all of the above fails then it falls back to the raw hexdata
Adds a data-testId to make e2e easier

Related issues

Fixes: #2877

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-31T10:18:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-04T10:02:44Z

Builds ready [9da176e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1862 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1706	2186	1865	91	44
		domContentLoaded	1697	2155	1823	87	42
		load	1706	2186	1862	89	43
		domInteractive	17	98	42	22	10
		backgroundConnect	9	113	42	30	14
		firstReactRender	51	106	77	21	10
		getState	5	60	15	15	7
		initialActions	0	1	0	0	0
		loadScripts	1224	1601	1333	74	36
		setupStore	12	74	29	21	10
		uiStartup	1910	2410	2049	95	46

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 50 Bytes (0.00%)
common: 0 Bytes (0.00%)

pedronfigueiredo · 2024-11-08T14:46:11Z

test/e2e/page-objects/pages/confirmations/redesign/advanced-details-transaction-confirmation.ts

+import { RawLocator } from '../../../common';
+import TransactionConfirmation from './transaction-confirmation';
+
+class AdvancedDetailsTransactionConfirmation extends TransactionConfirmation {


These properties and methods could live directly inside TransactionConfirmation, since all transaction confirmations have the advanced details related to this test.

This way, one could refer to the methods on this class directly, but also from any of the confirmation screen classes that extend it, such as SetApprovalForAllTransactionConfirmation or TokenTransferTransactionConfirmation.

metamaskbot · 2024-11-14T11:57:44Z

Builds ready [57370e1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1872 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1708	2266	1878	142	68
		domContentLoaded	1692	2244	1845	143	69
		load	1709	2258	1872	141	68
		domInteractive	28	246	87	64	30
		backgroundConnect	9	70	31	19	9
		firstReactRender	47	112	95	20	10
		getState	5	53	17	17	8
		initialActions	0	0	0	0	0
		loadScripts	1207	1697	1360	116	56
		setupStore	5	60	15	18	9
		uiStartup	1857	2468	2076	165	79

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 50 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-14T13:55:54Z

Builds ready [744b726]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1898 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1699	2448	1902	192	92
		domContentLoaded	1639	2389	1858	187	90
		load	1647	2406	1898	189	91
		domInteractive	30	97	61	18	9
		backgroundConnect	9	92	43	24	11
		firstReactRender	54	207	99	30	15
		getState	4	47	12	11	5
		initialActions	0	1	0	0	0
		loadScripts	1211	1927	1374	161	77
		setupStore	5	60	19	20	10
		uiStartup	1843	2633	2107	208	100

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 50 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-19T07:20:50Z

Builds ready [5072011]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2002 ± 112 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1787	2910	2006	247	119
		domContentLoaded	1725	2825	1967	234	113
		load	1787	2834	2002	234	112
		domInteractive	28	181	49	32	15
		backgroundConnect	10	100	34	26	13
		firstReactRender	49	98	66	14	7
		getState	45	103	85	19	9
		initialActions	0	1	0	0	0
		loadScripts	1264	2247	1477	208	100
		setupStore	6	51	12	12	6
		uiStartup	2028	3159	2270	257	124

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 50 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-27T11:12:20Z

Builds ready [209cb00]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1776 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	465	2151	1710	327	157
		domContentLoaded	1537	2069	1733	150	72
		load	1551	2159	1776	171	82
		domInteractive	21	72	37	14	7
		backgroundConnect	9	103	39	29	14
		firstReactRender	16	74	32	20	9
		getState	4	71	21	20	9
		initialActions	0	1	0	0	0
		loadScripts	1124	1607	1279	120	57
		setupStore	7	52	13	13	6
		uiStartup	1739	2379	1980	173	83

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 50 Bytes (0.00%)
common: 0 Bytes (0.00%)

pnarayanaswamy added 2 commits October 29, 2024 12:10

test: add tests to verify transaction decoding

1106ee6

test: Add tests for transaction decoding

ee3cd5a

pnarayanaswamy requested a review from a team as a code owner October 31, 2024 10:18

github-actions bot added the team-confirmations Push issues to confirmations team label Oct 31, 2024

pnarayanaswamy added 2 commits October 31, 2024 11:19

test: remove ppom test file

007a299

test: add test for uniswap and data test if

ef21d26

pnarayanaswamy requested a review from a team as a code owner November 1, 2024 10:02

pnarayanaswamy added 5 commits November 1, 2024 11:04

test: add page object file

6890dd7

Merge branch 'develop' into transaction-decoding

7902622

test: fix lint

8f16365

Merge branch 'develop' into transaction-decoding

847c86b

test: fix scrolling error on Firefox

9da176e

OGPoyraz previously approved these changes Nov 4, 2024

View reviewed changes

pedronfigueiredo reviewed Nov 8, 2024

View reviewed changes

Merge branch 'develop' into transaction-decoding

57370e1

test: address review move account details page to transactions

744b726

pnarayanaswamy dismissed OGPoyraz’s stale review via 744b726 November 14, 2024 13:07

Merge branch 'develop' into transaction-decoding

5072011

pedronfigueiredo previously approved these changes Nov 19, 2024

View reviewed changes

digiwand previously approved these changes Nov 25, 2024

View reviewed changes

OGPoyraz previously approved these changes Nov 26, 2024

View reviewed changes

pnarayanaswamy added this pull request to the merge queue Nov 26, 2024

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 26, 2024

pnarayanaswamy added this pull request to the merge queue Nov 26, 2024

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 26, 2024

pnarayanaswamy added this pull request to the merge queue Nov 27, 2024

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 27, 2024

pnarayanaswamy added this pull request to the merge queue Nov 27, 2024

pnarayanaswamy removed this pull request from the merge queue due to a manual request Nov 27, 2024

pnarayanaswamy added 2 commits November 27, 2024 15:52

Merge branch 'develop' into transaction-decoding

26621c0

chore: lint fix

61a6179

pnarayanaswamy dismissed stale reviews from pedronfigueiredo, digiwand, and OGPoyraz via 61a6179 November 27, 2024 09:45

Joj501 approved these changes Nov 27, 2024

View reviewed changes

chore: lint fix

209cb00

pedronfigueiredo approved these changes Nov 27, 2024

View reviewed changes

digiwand approved these changes Nov 27, 2024

View reviewed changes

pnarayanaswamy added this pull request to the merge queue Nov 27, 2024

Merged via the queue into develop with commit ab394d0 Nov 27, 2024
75 checks passed

pnarayanaswamy deleted the transaction-decoding branch November 27, 2024 12:46

github-actions bot locked and limited conversation to collaborators Nov 27, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add e2e for transaction decoding #28204

test: add e2e for transaction decoding #28204

pnarayanaswamy commented Oct 31, 2024 •

edited

Loading

github-actions bot commented Oct 31, 2024

metamaskbot commented Nov 4, 2024

pedronfigueiredo Nov 8, 2024

pnarayanaswamy Nov 19, 2024

metamaskbot commented Nov 14, 2024

metamaskbot commented Nov 14, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 27, 2024

test: add e2e for transaction decoding #28204

test: add e2e for transaction decoding #28204

Conversation

pnarayanaswamy commented Oct 31, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 31, 2024

metamaskbot commented Nov 4, 2024

pedronfigueiredo Nov 8, 2024

Choose a reason for hiding this comment

pnarayanaswamy Nov 19, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 14, 2024

metamaskbot commented Nov 14, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 27, 2024

pnarayanaswamy commented Oct 31, 2024 •

edited

Loading