feat(Solana): add "Add a new Solana account" link to the account creation dialog #28270

ulissesferreira · 2024-11-04T16:25:25Z

Description

Adds a "Add a new Solana account" link to the account creation dialog:

Related issues

Fixes:
SOL-24 [Setup] Add "Add a new Solana account (Beta)" button to the account picker

Manual testing steps

Build and load the extension locally
Open the account picker
Click on "Add account or hardware wallet"
Click on "Add a new Solana wallet (Beta)"
A new Solana wallet should have been created, using the same seed phrase used for Ethereum accounts

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…tion dialog

github-actions · 2024-11-04T16:25:38Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…ask/metamask-extension into SOL-24-add-new-solana-account-link

danroc · 2024-11-07T11:13:14Z

I updated the branch because we had flaky tests that were removed in the develop branch, this should improve the stability of this PR!

metamaskbot · 2024-11-07T12:22:57Z

Builds ready [5987b17]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2202 ± 213 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	295	3559	1969	792	381
		domContentLoaded	1752	3484	2173	428	206
		load	1761	3563	2202	443	213
		domInteractive	15	89	55	22	10
		backgroundConnect	8	83	25	21	10
		firstReactRender	56	285	116	44	21
		getState	5	65	26	22	11
		initialActions	0	1	0	0	0
		loadScripts	1291	2474	1617	321	154
		setupStore	11	94	37	25	12
		uiStartup	1986	3811	2479	453	218

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 149 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 64 Bytes (0.00%)

ui/hooks/accounts/useMultichainClient.ts

ui/hooks/accounts/useMultichainClient.test.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

metamaskbot · 2024-11-07T15:46:11Z

Builds ready [fe6f4bf]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1825 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1599	2088	1829	113	54
		domContentLoaded	1588	1995	1789	101	48
		load	1601	2091	1825	112	54
		domInteractive	16	81	47	18	9
		backgroundConnect	9	99	34	23	11
		firstReactRender	48	293	90	51	24
		getState	4	61	18	20	9
		initialActions	0	1	0	0	0
		loadScripts	1151	1502	1312	81	39
		setupStore	11	58	24	18	9
		uiStartup	1786	2369	2034	156	75

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 149 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 64 Bytes (0.00%)

darkwing · 2024-11-07T21:34:47Z

I was able to see this with:

diff --git a/builds.yml b/builds.yml
index 2442ad5147..5320b135aa 100644
--- a/builds.yml
+++ b/builds.yml
@@ -18,6 +18,7 @@ buildTypes:
     features:
       - build-main
       - keyring-snaps
+      - solana
     # Additional env variables that are specific to this build
     env:
       - INFURA_PROD_PROJECT_ID

Is there a better way to build / start this?

zone-live · 2024-11-08T09:35:45Z

I was able to see this with:

diff --git a/builds.yml b/builds.yml
index 2442ad5147..5320b135aa 100644
--- a/builds.yml
+++ b/builds.yml
@@ -18,6 +18,7 @@ buildTypes:
     features:
       - build-main
       - keyring-snaps
+      - solana
     # Additional env variables that are specific to this build
     env:
       - INFURA_PROD_PROJECT_ID

Is there a better way to build / start this?

Thats it, you're correct. Great catch, ty 👍🏼

metamaskbot · 2024-11-08T10:15:31Z

Builds ready [c4623fb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1827 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1577	2379	1835	206	99
		domContentLoaded	1568	2347	1799	204	98
		load	1577	2383	1827	207	99
		domInteractive	20	108	48	23	11
		backgroundConnect	9	88	30	23	11
		firstReactRender	46	211	91	43	21
		getState	4	59	21	18	9
		initialActions	0	1	0	0	0
		loadScripts	1132	1775	1320	170	82
		setupStore	11	93	45	24	12
		uiStartup	1766	2619	2062	237	114

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 149 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 64 Bytes (0.00%)

ui/hooks/accounts/useMultichainClient.ts

metamaskbot · 2024-11-08T14:02:46Z

Builds ready [ba2a6f0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1961 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	287	2512	1814	519	249
		domContentLoaded	1672	2477	1925	206	99
		load	1726	2549	1961	214	103
		domInteractive	18	106	54	22	10
		backgroundConnect	7	88	36	25	12
		firstReactRender	48	299	117	62	30
		getState	4	86	19	25	12
		initialActions	0	0	0	0	0
		loadScripts	1157	1870	1399	180	86
		setupStore	11	96	26	25	12
		uiStartup	1899	2961	2241	295	142

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 149 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 64 Bytes (0.00%)

ui/hooks/accounts/useMultichainWalletSnapClient.ts

metamaskbot · 2024-11-08T15:19:14Z

Builds ready [ccdbb50]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1856 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	313	2443	1789	379	182
		domContentLoaded	1614	2426	1819	167	80
		load	1665	2444	1856	173	83
		domInteractive	19	116	46	27	13
		backgroundConnect	7	96	40	29	14
		firstReactRender	47	205	111	51	24
		getState	4	88	25	27	13
		initialActions	0	1	0	0	0
		loadScripts	1157	1900	1327	154	74
		setupStore	11	101	35	25	12
		uiStartup	1818	2657	2131	220	106

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 149 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 64 Bytes (0.00%)

zone-live and others added 5 commits October 30, 2024 14:21

chore: initial setup

ba54e2e

chore: prettier and test update

8492b1e

chore: text update

f1feedf

fix: remove unnecessary things

c6a76e3

feat(Solana): add "Add a new Solana account" link to the account crea…

1f8d855

…tion dialog

github-actions bot added the team-sol PRs from the Solana snap team label Nov 4, 2024

zone-live and others added 7 commits November 7, 2024 09:55

chore: fix conflicts and update branch

4c79f4f

chore: adds lock file updates and resets .yarnrc.yml

f2a399c

chore: adds solana code fences

2f5aa2c

chore: improvements

b98defc

Merge branch 'develop' into SOL-24-add-new-solana-account-link

802f669

chore: updates test structure

c070724

Merge branch 'SOL-24-add-new-solana-account-link' of github.com:MetaM…

821701a

…ask/metamask-extension into SOL-24-add-new-solana-account-link

zone-live added 3 commits November 7, 2024 11:14

chore: prettier run

b3d0ea3

chore: not needed right now

fd1828e

chore: clean up comment

5987b17

zone-live marked this pull request as ready for review November 7, 2024 13:58

zone-live requested review from a team as code owners November 7, 2024 13:58

aganglada previously approved these changes Nov 7, 2024

View reviewed changes

ccharly reviewed Nov 7, 2024

View reviewed changes

Update ui/hooks/accounts/useMultichainClient.ts

b61baeb

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

zone-live dismissed aganglada’s stale review via b61baeb November 7, 2024 14:51

zone-live and others added 2 commits November 7, 2024 14:52

Update ui/hooks/accounts/useMultichainClient.ts

5983d35

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

chore: naming improvements

fe6f4bf

chore: update

9ce847e

fix: code fence

c4623fb

zone-live requested a review from darkwing November 8, 2024 10:29

aganglada previously approved these changes Nov 8, 2024

View reviewed changes

ccharly reviewed Nov 8, 2024

View reviewed changes

ui/hooks/accounts/useMultichainClient.ts Outdated Show resolved Hide resolved

ui/hooks/accounts/useMultichainClient.ts Outdated Show resolved Hide resolved

zone-live added 2 commits November 8, 2024 12:00

chore: rename method and hook

26e7a72

chore: prettier

aabe913

zone-live dismissed aganglada’s stale review via aabe913 November 8, 2024 12:02

chore: update git info about deletes

ba2a6f0

zone-live requested review from ccharly and aganglada November 8, 2024 14:11

ccharly reviewed Nov 8, 2024

View reviewed changes

ui/hooks/accounts/useMultichainWalletSnapClient.ts Outdated Show resolved Hide resolved

chore: adds comment back

ccdbb50

ccharly approved these changes Nov 8, 2024

View reviewed changes

dabossdana approved these changes Nov 8, 2024

View reviewed changes

darkwing approved these changes Nov 8, 2024

View reviewed changes

zone-live added this pull request to the merge queue Nov 8, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024

zone-live added this pull request to the merge queue Nov 8, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2024

zone-live added this pull request to the merge queue Nov 8, 2024

Merged via the queue into develop with commit d2ddf24 Nov 8, 2024
85 checks passed

zone-live deleted the SOL-24-add-new-solana-account-link branch November 8, 2024 18:13

github-actions bot locked and limited conversation to collaborators Nov 8, 2024

metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Solana): add "Add a new Solana account" link to the account creation dialog #28270

feat(Solana): add "Add a new Solana account" link to the account creation dialog #28270

ulissesferreira commented Nov 4, 2024 •

edited by zone-live

Loading

github-actions bot commented Nov 4, 2024

danroc commented Nov 7, 2024

metamaskbot commented Nov 7, 2024

metamaskbot commented Nov 7, 2024

darkwing commented Nov 7, 2024

zone-live commented Nov 8, 2024

metamaskbot commented Nov 8, 2024

metamaskbot commented Nov 8, 2024

metamaskbot commented Nov 8, 2024

feat(Solana): add "Add a new Solana account" link to the account creation dialog #28270

feat(Solana): add "Add a new Solana account" link to the account creation dialog #28270

Conversation

ulissesferreira commented Nov 4, 2024 • edited by zone-live Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 4, 2024

danroc commented Nov 7, 2024

metamaskbot commented Nov 7, 2024

metamaskbot commented Nov 7, 2024

darkwing commented Nov 7, 2024

zone-live commented Nov 8, 2024

metamaskbot commented Nov 8, 2024

metamaskbot commented Nov 8, 2024

metamaskbot commented Nov 8, 2024

ulissesferreira commented Nov 4, 2024 •

edited by zone-live

Loading