Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add metric trait for privacy mode #28335

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: Add metric trait for privacy mode #28335

merged 2 commits into from
Nov 11, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 6, 2024

Description

Adds a user trait for if privacy mode is enabled.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open debugger
  2. Put a breakpoint in app/scripts/controllers/metametrics.ts's _buildUserTraitsObject function
  3. See value being passed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 6, 2024 23:02
@darkwing darkwing added team-wallet-ux portfolio-view Used for PRs and issues related to Q4 2024 portfolio view labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [754b572]
Page Load Metrics (1962 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51023551896363174
domContentLoaded16782260192815675
load16872281196217081
domInteractive227443147
backgroundConnect8102372914
firstReactRender503831147134
getState586172110
initialActions01000
loadScripts11941684141013163
setupStore1198342713
uiStartup190929832228236113
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 70 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 43 Bytes (0.00%)

gambinish
gambinish previously approved these changes Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1ea6170]
Page Load Metrics (1962 ± 166 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint165832701966345166
domContentLoaded165031601926322155
load165832691962345166
domInteractive21239514521
backgroundConnect9107413015
firstReactRender55154972412
getState56818178
initialActions01000
loadScripts119622011404225108
setupStore65717189
uiStartup186034942165355171
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 70 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 43 Bytes (0.00%)

@darkwing darkwing added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit d887c79 Nov 11, 2024
76 checks passed
@darkwing darkwing deleted the privacy-mode-metrics branch November 11, 2024 22:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants