-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add metric trait for privacy mode #28335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
added
team-wallet-ux
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
labels
Nov 6, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
force-pushed
the
privacy-mode-metrics
branch
from
November 6, 2024 23:14
518c0c8
to
754b572
Compare
Builds ready [754b572]
Page Load Metrics (1962 ± 81 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gambinish
previously approved these changes
Nov 7, 2024
darkwing
force-pushed
the
privacy-mode-metrics
branch
from
November 11, 2024 20:11
754b572
to
c7416ce
Compare
darkwing
force-pushed
the
privacy-mode-metrics
branch
from
November 11, 2024 20:23
c7416ce
to
8df6e70
Compare
gambinish
approved these changes
Nov 11, 2024
Builds ready [1ea6170]
Page Load Metrics (1962 ± 166 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sahar-fehri
approved these changes
Nov 11, 2024
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
portfolio-view
Used for PRs and issues related to Q4 2024 portfolio view
release-12.8.0
Issue or pull request that will be included in release 12.8.0
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a user trait for if privacy mode is enabled.
Related issues
Fixes:
Manual testing steps
app/scripts/controllers/metametrics.ts
's_buildUserTraitsObject
functionScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist