Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add metric trait for token network filter preference #28336

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 7, 2024

Description

Adds a user trait for network filter preference for PortfolioView™

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open debugger
  2. Put a breakpoint in app/scripts/controllers/metametrics.ts's _buildUserTraitsObject function
  3. See value being passed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 7, 2024 05:33
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 7, 2024
vinnyhoward
vinnyhoward previously approved these changes Nov 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [776c126]
Page Load Metrics (1847 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30821871774365175
domContentLoaded16282170182113263
load16412188184713565
domInteractive328650136
backgroundConnect986282110
firstReactRender48149962110
getState378172110
initialActions01000
loadScripts11671706135112058
setupStore65712157
uiStartup18372408203914771
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 121 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 52 Bytes (0.00%)

@gambinish gambinish added this pull request to the merge queue Nov 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1d13965]
Page Load Metrics (1793 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16082173179314570
domContentLoaded15962154176114570
load16122175179315072
domInteractive267842178
backgroundConnect1182342411
firstReactRender1773372210
getState56215157
initialActions01000
loadScripts11761597129511555
setupStore66319209
uiStartup18182375198315775
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 99 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 52 Bytes (0.00%)

Merged via the queue into develop with commit 193da76 Nov 26, 2024
75 checks passed
@gambinish gambinish deleted the metrics-network-filter branch November 26, 2024 21:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants