Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: Negate privacy mode in Send screen" #28360

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 7, 2024

Reverts #28248

Need to revert this before #28021

@darkwing darkwing requested review from a team as code owners November 7, 2024 16:00
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 7, 2024
@darkwing darkwing changed the title Revert "fix: Negate privacy mode in Send screen" fix: Revert "fix: Negate privacy mode in Send screen" Nov 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [25c04f1]
Page Load Metrics (1937 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16432337194514067
domContentLoaded16292239190413163
load16402343193714268
domInteractive208455199
backgroundConnect10135383517
firstReactRender502941105125
getState590152110
initialActions01000
loadScripts11981665141210751
setupStore1168322311
uiStartup184228612194208100
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -280 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing added this pull request to the merge queue Nov 7, 2024
Merged via the queue into develop with commit 1614632 Nov 7, 2024
86 of 87 checks passed
@darkwing darkwing deleted the revert-28248-fix-privacy-mode-send branch November 7, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants