feat: update signature controller and integrate decoding api #28397

jpuri · 2024-11-11T04:59:01Z

Description

Integrate decoding api.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3623

Manual testing steps

Enable decoding api locally using env variables
Submit a permit request
Check that decoding api results are present in confirmation object

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-11T04:59:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-11-11T05:00:54Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/signature-controller@21.1.0	network	`+1`	420 kB	metamaskbot

🚮 Removed packages: npm/@metamask/signature-controller@21.0.0

View full report↗︎

socket-security · 2024-11-11T05:00:55Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/signature-controller@21.1.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

jpuri · 2024-11-11T05:02:56Z

@SocketSecurity ignore npm/@metamask/signature-controller@21.1.0

jpuri · 2024-11-11T05:06:29Z

@metamaskbot update-policies

metamaskbot · 2024-11-11T05:15:49Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

…sion into decoding_api_int

metamaskbot · 2024-11-11T05:53:46Z

Builds ready [4b04930]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1994 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	304	2560	1895	409	196
		domContentLoaded	1737	2498	1975	209	100
		load	1755	2504	1994	206	99
		domInteractive	31	99	55	19	9
		backgroundConnect	9	69	24	17	8
		firstReactRender	59	206	109	32	15
		getState	5	84	25	23	11
		initialActions	0	1	0	0	0
		loadScripts	1239	1924	1436	179	86
		setupStore	6	61	23	23	11
		uiStartup	1929	3059	2248	285	137

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.88 KiB (0.06%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

app/scripts/metamask-controller.js

builds.yml

Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>

metamaskbot · 2024-11-12T13:35:17Z

Builds ready [a6862f0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1881 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	384	2198	1709	468	225
		domContentLoaded	1663	2325	1844	186	89
		load	1674	2331	1881	190	91
		domInteractive	17	96	52	23	11
		backgroundConnect	8	138	39	30	15
		firstReactRender	62	283	107	43	20
		getState	5	81	18	22	11
		initialActions	0	1	0	0	0
		loadScripts	1212	1742	1366	147	70
		setupStore	6	69	11	14	7
		uiStartup	1865	3011	2119	300	144

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.88 KiB (0.06%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-12T16:02:35Z

Builds ready [c77528d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2100 ± 104 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1784	2727	2097	220	106
		domContentLoaded	1760	2657	2067	210	101
		load	1785	2701	2100	217	104
		domInteractive	16	192	53	38	18
		backgroundConnect	9	93	33	26	12
		firstReactRender	50	296	131	71	34
		getState	5	92	22	24	12
		initialActions	0	1	0	0	0
		loadScripts	1262	2039	1531	174	83
		setupStore	6	54	17	17	8
		uiStartup	2016	2951	2407	260	125

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.88 KiB (0.06%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-13T00:35:16Z

Builds ready [17f65af]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1888 ± 109 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	368	2448	1817	398	191
		domContentLoaded	1668	2385	1854	211	102
		load	1688	2453	1888	227	109
		domInteractive	27	84	49	18	9
		backgroundConnect	9	92	32	26	13
		firstReactRender	47	183	97	28	13
		getState	4	47	10	10	5
		initialActions	0	1	0	0	0
		loadScripts	1207	1882	1369	176	85
		setupStore	5	55	16	18	9
		uiStartup	1863	2834	2096	263	126

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.88 KiB (0.05%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-13T11:27:13Z

Builds ready [2e1e012]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2250 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	361	2621	2153	460	221
		domContentLoaded	1859	2599	2216	203	97
		load	1870	2625	2250	207	99
		domInteractive	28	114	60	21	10
		backgroundConnect	8	92	45	30	14
		firstReactRender	61	397	152	89	43
		getState	6	74	23	21	10
		initialActions	0	1	0	0	0
		loadScripts	1299	2035	1637	177	85
		setupStore	6	60	23	21	10
		uiStartup	2092	3155	2593	298	143

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.88 KiB (0.05%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

jpuri added 2 commits November 11, 2024 10:23

Update signature controller and integrate decoding api

602fb20

Update signature controller and integrate decoding api

fc6ab5e

jpuri added the team-confirmations Push issues to confirmations team label Nov 11, 2024

jpuri requested a review from a team as a code owner November 11, 2024 04:59

Update LavaMoat policies

228796c

metamaskbot requested a review from a team as a code owner November 11, 2024 05:15

jpuri added 2 commits November 11, 2024 10:47

update

2943ebf

Merge branch 'decoding_api_int' of github.com:MetaMask/metamask-exten…

4b04930

…sion into decoding_api_int

matthewwalsh0 requested changes Nov 12, 2024

View reviewed changes

app/scripts/metamask-controller.js Show resolved Hide resolved

app/scripts/metamask-controller.js Show resolved Hide resolved

builds.yml Outdated Show resolved Hide resolved

jpuri requested a review from matthewwalsh0 November 12, 2024 11:36

jpuri enabled auto-merge November 12, 2024 11:36

Update builds.yml

464d160

Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>

matthewwalsh0 approved these changes Nov 12, 2024

View reviewed changes

jpuri added 3 commits November 12, 2024 17:45

Merge branch 'develop' into decoding_api_int

bf5feac

Merge branch 'develop' into decoding_api_int

37dd69d

Merge branch 'develop' into decoding_api_int

a6862f0

Merge branch 'develop' into decoding_api_int

c77528d

Merge branch 'develop' into decoding_api_int

17f65af

Merge branch 'develop' into decoding_api_int

2e1e012

pedronfigueiredo approved these changes Nov 13, 2024

View reviewed changes

jpuri added this pull request to the merge queue Nov 13, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024

jpuri added this pull request to the merge queue Nov 13, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024

jpuri added this pull request to the merge queue Nov 13, 2024

Merged via the queue into develop with commit e9ffd0a Nov 13, 2024
77 checks passed

jpuri deleted the decoding_api_int branch November 13, 2024 23:27

github-actions bot locked and limited conversation to collaborators Nov 13, 2024

metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update signature controller and integrate decoding api #28397

feat: update signature controller and integrate decoding api #28397

jpuri commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

socket-security bot commented Nov 11, 2024 •

edited

Loading

socket-security bot commented Nov 11, 2024 •

edited

Loading

jpuri commented Nov 11, 2024

jpuri commented Nov 11, 2024

metamaskbot commented Nov 11, 2024

metamaskbot commented Nov 11, 2024

metamaskbot commented Nov 12, 2024

metamaskbot commented Nov 12, 2024

metamaskbot commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

feat: update signature controller and integrate decoding api #28397

feat: update signature controller and integrate decoding api #28397

Conversation

jpuri commented Nov 11, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 11, 2024

socket-security bot commented Nov 11, 2024 • edited Loading

socket-security bot commented Nov 11, 2024 • edited Loading

Next steps

jpuri commented Nov 11, 2024

jpuri commented Nov 11, 2024

metamaskbot commented Nov 11, 2024

metamaskbot commented Nov 11, 2024

metamaskbot commented Nov 12, 2024

metamaskbot commented Nov 12, 2024

metamaskbot commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

socket-security bot commented Nov 11, 2024 •

edited

Loading

socket-security bot commented Nov 11, 2024 •

edited

Loading