Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v12.6.1 RC #28404

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Version v12.6.1 RC #28404

merged 3 commits into from
Nov 13, 2024

Conversation

metamaskbot
Copy link
Collaborator

📦 🚀

@github-actions github-actions bot added the team-bot Bot team (for MetaMask Bot) label Nov 11, 2024
@metamaskbot
Copy link
Collaborator Author

Builds ready [91a4ec4]
Page Load Metrics (1804 ± 130 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint158525441802256123
domContentLoaded155123741753219105
load158526201804271130
domInteractive178842188
backgroundConnect10234525928
firstReactRender452051034019
getState4132213216
initialActions01000
loadScripts11141784129116981
setupStore10105282713
uiStartup175536062053460221

@metamaskbot
Copy link
Collaborator Author

Builds ready [f2865d1]
Page Load Metrics (2065 ± 162 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint172029842058313150
domContentLoaded170126331994249120
load172031192065338162
domInteractive22106542311
backgroundConnect12412669546
firstReactRender543011146431
getState5225365024
initialActions01000
loadScripts122519801484213102
setupStore12151453718
uiStartup191145732387591284

## **Description**

Add gas limit fix to changelog.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28410?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot
Copy link
Collaborator Author

Builds ready [bf078ad]
Page Load Metrics (2012 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint175727022015229110
domContentLoaded167626881954221106
load168027022012246118
domInteractive197447157
backgroundConnect7307588441
firstReactRender792461224521
getState5112243014
initialActions01000
loadScripts12101685142012560
setupStore11146394120
uiStartup189235872326416200

@danjm danjm marked this pull request as ready for review November 13, 2024 13:03
@danjm danjm requested a review from a team as a code owner November 13, 2024 13:03
@danjm danjm merged commit aa32744 into master Nov 13, 2024
79 of 80 checks passed
@danjm danjm deleted the Version-v12.6.1 branch November 13, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-bot Bot team (for MetaMask Bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants