Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Begin introducing patterns for Multichain AssetList #28429

Merged

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Nov 13, 2024

Description

This PR introduces some non-breaking patterns from #28386

The idea is to introduce this as a smaller PR to reduce the diff in #28386 to make it easier to review

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

App should be fully functional with no regressions

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title Feat/mmassets 432 network filter extension prep updates chore: Begin introducing patterns for Multichain AssetList Nov 13, 2024
@gambinish gambinish marked this pull request as ready for review November 13, 2024 05:15
@gambinish gambinish requested review from a team as code owners November 13, 2024 05:15
@metamaskbot
Copy link
Collaborator

Builds ready [f9fa8da]
Page Load Metrics (1787 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16492352179914369
domContentLoaded16402178175811455
load16512267178712761
domInteractive167440147
backgroundConnect897312311
firstReactRender452821085627
getState55917209
initialActions00000
loadScripts1183157212878541
setupStore54711126
uiStartup18362592202116780
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 233 Bytes (0.00%)
  • common: 153 Bytes (0.00%)

jonybur
jonybur previously approved these changes Nov 13, 2024
ui/pages/asset/util.ts Outdated Show resolved Hide resolved
ui/pages/asset/util.ts Outdated Show resolved Hide resolved
@gambinish gambinish requested a review from a team as a code owner November 13, 2024 17:20
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing and all works great!

@gambinish gambinish added this pull request to the merge queue Nov 13, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [25c27ea]
Page Load Metrics (1698 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22219971500520250
domContentLoaded1530190316807335
load1538192116987737
domInteractive247546126
backgroundConnect76421199
firstReactRender45208944220
getState46114199
initialActions01000
loadScripts1112137112185526
setupStore56716199
uiStartup17232155191612962
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 265 Bytes (0.00%)
  • common: 153 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@gambinish gambinish added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@gambinish gambinish added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@gambinish gambinish added this pull request to the merge queue Nov 13, 2024
@gambinish gambinish removed the request for review from a team November 13, 2024 19:21
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@gambinish gambinish added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [572f998]
Page Load Metrics (1911 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16582283191514871
domContentLoaded16472118188012761
load16582306191115072
domInteractive29257604823
backgroundConnect9194334120
firstReactRender882821224421
getState5102142311
initialActions01000
loadScripts12011607138810149
setupStore67713199
uiStartup186928312180233112
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 265 Bytes (0.00%)
  • common: 153 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [bc2f132]
Page Load Metrics (2138 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34123962050422203
domContentLoaded19242380210614369
load19412395213815273
domInteractive338757189
backgroundConnect876282311
firstReactRender942131323215
getState767242110
initialActions01000
loadScripts13891743155211756
setupStore76014136
uiStartup21812915240519895
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 265 Bytes (0.00%)
  • common: 153 Bytes (0.00%)

@seaona seaona added this pull request to the merge queue Nov 14, 2024
Merged via the queue into develop with commit 0a5eb58 Nov 14, 2024
77 checks passed
@seaona seaona deleted the feat/mmassets-432_network-filter-extension--prep-updates branch November 14, 2024 07:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants