-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Begin introducing patterns for Multichain AssetList #28429
Merged
seaona
merged 27 commits into
develop
from
feat/mmassets-432_network-filter-extension--prep-updates
Nov 14, 2024
Merged
chore: Begin introducing patterns for Multichain AssetList #28429
seaona
merged 27 commits into
develop
from
feat/mmassets-432_network-filter-extension--prep-updates
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gambinish
changed the title
Feat/mmassets 432 network filter extension prep updates
chore: Begin introducing patterns for Multichain AssetList
Nov 13, 2024
Builds ready [f9fa8da]
Page Load Metrics (1787 ± 61 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jonybur
previously approved these changes
Nov 13, 2024
darkwing
reviewed
Nov 13, 2024
darkwing
reviewed
Nov 13, 2024
jonybur
approved these changes
Nov 13, 2024
darkwing
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing and all works great!
Builds ready [25c27ea]
Page Load Metrics (1698 ± 37 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2024
dabossdana
approved these changes
Nov 13, 2024
Builds ready [572f998]
Page Load Metrics (1911 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [bc2f132]
Page Load Metrics (2138 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
deleted the
feat/mmassets-432_network-filter-extension--prep-updates
branch
November 14, 2024 07:59
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some non-breaking patterns from #28386
The idea is to introduce this as a smaller PR to reduce the diff in #28386 to make it easier to review
Related issues
Fixes: N/A
Manual testing steps
App should be fully functional with no regressions
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist