fix: fix ConnectPage when a non-EVM account is selected

[ccharly]

Description

The currently selected non-EVM account was part of the requested account on during the account connection flow. The ConnectPage was allowing to "confirm" the request even if the UI was showing 0 account.

To fix this, we no longer uses the currently selected account if this account is not EVM-compatible.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/670

Manual testing steps

1. yarn start:flask
2. Enable Bitcoin support
3. Create a Bitcoin account
4. Select this account
5. Go to: https://metamask.github.io/test-dapp/
6. Try to connect your accounts
   • None accounts should be selected by default
   • You should not be able to "confirm" the dialog

Screenshots/Recordings

Before

If you try to connect, you will get:

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [3a8d449]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1898 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1717	2180	1898	113	54
		domContentLoaded	1704	2170	1867	104	50
		load	1716	2183	1898	114	55
		domInteractive	21	256	65	57	27
		backgroundConnect	7	79	33	21	10
		firstReactRender	89	119	101	7	3
		getState	5	61	21	19	9
		initialActions	0	1	0	0	0
		loadScripts	1222	1670	1370	93	45
		setupStore	6	56	12	14	7
		uiStartup	1912	2393	2101	123	59

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 23 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[gantunesr]

LGTM. Not approving yet since there are unresolved comments

[metamaskbot]

Builds ready [6b8c02a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2231 ± 119 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	280	3073	1936	719	345
		domContentLoaded	1872	3062	2193	251	120
		load	1923	3081	2231	247	119
		domInteractive	29	151	57	31	15
		backgroundConnect	9	80	35	23	11
		firstReactRender	78	276	121	45	22
		getState	7	81	28	25	12
		initialActions	0	1	0	0	0
		loadScripts	1344	2347	1606	213	102
		setupStore	6	58	16	16	8
		uiStartup	2166	3367	2490	267	128

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 23 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [a9c8cfb]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2031 ± 242 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	395	2662	1676	567	272
		domContentLoaded	1625	3730	2005	499	240
		load	1647	3755	2031	504	242
		domInteractive	23	142	53	34	16
		backgroundConnect	9	101	33	28	13
		firstReactRender	68	241	125	40	19
		getState	4	52	13	12	6
		initialActions	0	1	0	0	0
		loadScripts	1150	2986	1481	428	205
		setupStore	6	75	22	23	11
		uiStartup	1842	4083	2289	552	265

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 23 Bytes (0.00%)
• common: 0 Bytes (0.00%)