feat: Upgrade assets controllers to 43 with multichain polling for token lists + detection #28447

bergeron · 2024-11-13T20:30:59Z

Description

This upgrades assets controllers to version 43. It allows us to poll for token lists and token detection across chains.

Related issues

Fixes:

Manual testing steps

Onboard to metamask
Verify your erc20 tokens are detected
Click a token
Verify data on token details page
Switch networks
Repeat steps 2-4

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-13T20:31:16Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

bergeron · 2024-11-13T20:42:34Z

@metamaskbot update-policies

metamaskbot · 2024-11-13T20:54:40Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

bergeron · 2024-11-13T20:56:33Z

app/scripts/metamask-controller.js

@@ -7205,14 +7222,14 @@ export default class MetamaskController extends EventEmitter {

    this.tokenListController.updatePreventPollingOnNetworkRestart(!newEnabled);


I've never understood the purpose of preventPollingOnNetworkRestart, so I don't know whether it still makes sense. When it's set to true, all it seems to do is reset the state when switching chains. Keeping it around for now.

I saw this same thing and had similar thoughts. Sounds good

socket-security · 2024-11-13T21:02:35Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/controller-utils@11.4.3	network	`0`	264 kB	metamaskbot

View full report↗︎

bergeron · 2024-11-13T21:12:09Z

@metamaskbot update-policies

metamaskbot · 2024-11-13T21:25:09Z

Policy update failed. You can review the logs or retry the policy update here

bergeron · 2024-11-13T21:25:25Z

@metamaskbot update-policies

metamaskbot · 2024-11-13T21:38:03Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

…Mask/metamask-extension into brian/upgrade-assets-controllers-43

bergeron · 2024-11-13T22:50:53Z

fixing e2e

bergeron · 2024-11-14T04:18:04Z

ui/pages/onboarding-flow/pin-extension/pin-extension.js

+      await dispatch(
+        toggleExternalServices(externalServicesOnboardingToggleState),
+      );


There was a race condition here.

When you disable basic functionality during onboarding, we don't actually flip the setting until this final page. But the toggle was not awaited, so there was a brief period where:

completedOnboarding == true

useExternalServices == true

And then it would quickly flip to false. But with this change useExternalServices will be false immediately upon leaving onboarding.

Accompanying changes in actions.ts

metamaskbot · 2024-11-14T05:45:37Z

Builds ready [1411c2a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1939 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	338	2269	1841	369	177
		domContentLoaded	1693	2324	1912	157	76
		load	1706	2330	1939	160	77
		domInteractive	24	88	42	16	8
		backgroundConnect	8	87	31	22	11
		firstReactRender	50	212	101	46	22
		getState	64	192	107	35	17
		initialActions	0	1	0	0	0
		loadScripts	1220	1750	1404	128	62
		setupStore	6	86	16	23	11
		uiStartup	1999	3040	2321	262	126

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -75 Bytes (-0.00%)
ui: 2.71 KiB (0.04%)
common: 3.42 KiB (0.04%)

bergeron · 2024-11-14T22:05:33Z

.yarn/patches/@metamask-assets-controllers-patch-9e00573eb4.patch

+diff --git a/dist/TokenDetectionController.cjs b/dist/TokenDetectionController.cjs
+index ab23c95d667357db365f925c4c4acce4736797f8..8fd5efde7a3c24080f8a43f79d10300e8c271245 100644
+--- a/dist/TokenDetectionController.cjs
+++ b/dist/TokenDetectionController.cjs


MetaMask/core#4928

metamaskbot · 2024-11-15T00:42:23Z

Builds ready [979a3af]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2213 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1972	2615	2231	188	90
		domContentLoaded	1944	2533	2180	178	85
		load	1961	2599	2213	189	91
		domInteractive	18	100	50	20	10
		backgroundConnect	7	85	29	20	10
		firstReactRender	56	300	134	89	43
		getState	51	209	119	38	18
		initialActions	0	1	0	0	0
		loadScripts	1405	1938	1644	152	73
		setupStore	6	86	20	23	11
		uiStartup	2258	3032	2658	238	114

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -75 Bytes (-0.00%)
ui: 2.8 KiB (0.04%)
common: 3.6 KiB (0.04%)

upgrade

f024224

metamaskbot added the team-assets label Nov 13, 2024

remove unit test

cfb46d1

bergeron and others added 2 commits November 13, 2024 12:42

Merge branch 'develop' into brian/upgrade-assets-controllers-43

2f36b23

Update LavaMoat policies

25f5ed0

bergeron commented Nov 13, 2024

View reviewed changes

yarn dedupe

6c216f8

add unit test

2822c58

Update LavaMoat policies

3d5323a

bergeron added 3 commits November 13, 2024 13:48

lint

ae198fb

Merge branch 'brian/upgrade-assets-controllers-43' of github.com:Meta…

e1f3843

…Mask/metamask-extension into brian/upgrade-assets-controllers-43

lint and fix test

b090b3c

bergeron added 6 commits November 13, 2024 15:58

onboarding

38fc254

fix race condition

6338a00

temporarily disable token detection polling

6b22521

patch

5206a35

package json

757d880

fix unit test

abf8e11

bergeron commented Nov 14, 2024

View reviewed changes

bergeron added 2 commits November 13, 2024 20:35

update sentry state

c662098

sentry state

8f1cfb1

Merge branch 'develop' into brian/upgrade-assets-controllers-43

1411c2a

bergeron added 4 commits November 14, 2024 13:20

Merge branch 'develop' into brian/upgrade-assets-controllers-43

05554a3

update patch

729d07d

dont poll when locked

21fcda3

remove commented out code

8b6391f

bergeron commented Nov 14, 2024

View reviewed changes

bergeron added 2 commits November 14, 2024 14:58

fix e2e tests

b635ab8

fix unit test

ec38722

bergeron marked this pull request as ready for review November 14, 2024 23:25

bergeron requested review from a team as code owners November 14, 2024 23:25

bergeron added 2 commits November 14, 2024 16:01

avoid calling hook different order

79a451f

lint

979a3af

darkwing approved these changes Nov 15, 2024

View reviewed changes

gambinish approved these changes Nov 15, 2024

View reviewed changes

bergeron added this pull request to the merge queue Nov 15, 2024

Merged via the queue into develop with commit a597a8e Nov 15, 2024
86 checks passed

bergeron deleted the brian/upgrade-assets-controllers-43 branch November 15, 2024 18:01

github-actions bot locked and limited conversation to collaborators Nov 15, 2024

metamaskbot added the release-12.8.1 Issue or pull request that will be included in release 12.8.1 label Nov 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Upgrade assets controllers to 43 with multichain polling for token lists + detection #28447

feat: Upgrade assets controllers to 43 with multichain polling for token lists + detection #28447

bergeron commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 13, 2024

bergeron commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

bergeron Nov 13, 2024 •

edited

Loading

gambinish Nov 15, 2024

socket-security bot commented Nov 13, 2024 •

edited

Loading

bergeron commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

bergeron commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

bergeron commented Nov 13, 2024

bergeron Nov 14, 2024 •

edited

Loading

metamaskbot commented Nov 14, 2024

bergeron Nov 14, 2024

metamaskbot commented Nov 15, 2024

		@@ -7205,14 +7222,14 @@ export default class MetamaskController extends EventEmitter {

		this.tokenListController.updatePreventPollingOnNetworkRestart(!newEnabled);

feat: Upgrade assets controllers to 43 with multichain polling for token lists + detection #28447

feat: Upgrade assets controllers to 43 with multichain polling for token lists + detection #28447

Conversation

bergeron commented Nov 13, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 13, 2024

bergeron commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

bergeron Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

gambinish Nov 15, 2024

Choose a reason for hiding this comment

socket-security bot commented Nov 13, 2024 • edited Loading

bergeron commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

bergeron commented Nov 13, 2024

metamaskbot commented Nov 13, 2024

bergeron commented Nov 13, 2024

bergeron Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Nov 14, 2024

bergeron Nov 14, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 15, 2024

bergeron commented Nov 13, 2024 •

edited

Loading

bergeron Nov 13, 2024 •

edited

Loading

socket-security bot commented Nov 13, 2024 •

edited

Loading

bergeron Nov 14, 2024 •

edited

Loading