feat: cross chain aggregated balance #28456

sahar-fehri · 2024-11-14T13:32:17Z

Description

Branch was ininitially based on top of #28276

This PR calculates balance for current account cross chains while not taking into account the test networks.

Related issues

Fixes:

Manual testing steps

Start the app with PORTFOLIO_VIEW=1

Go to main page and click on Ethereum network
Import your tokens
You should see the total balance in Fiat of your native + ERC20 tokens
Switch to another chain where you also have tokens; exp polygon
Notice that your total fiat balance is now total fiat balance on Ethereum + current native balance on polygon in fiat
Import any tokens you have on polygon
Notice that the total fiat balance now added up the sum of ERC20 tokens you had on Polygon
Click on the network filter and notice you can see aggregated balance on all networks and aggregated balance on the current network
Switch to "Current network" on the network filter and the main view should now show you the aggregated balance on this network.
Click on account item and notice that you now see the balance in fiat cross networks
Go to settings and turn on the setting "show native token as main balance"; and go back to home page.
You should now see your native balance in crypto
Click on network filter and you should still be able to see the all networks and current network aggregated balance in fiat.

Screenshots/Recordings

Before

After

Screen.Recording.2024-11-19.at.22.41.15.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ask-extension into brian/asset-controller-39

… brian/currency-rate-multichain-polling2

…MetaMask/metamask-extension into brian/multiexchangerate

… brian/multiexchangerate

gambinish

LGTM 🚀

metamaskbot · 2024-11-19T21:38:21Z

Builds ready [69ed10a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2108 ± 93 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1880	2564	2114	195	94
		domContentLoaded	1864	2504	2079	186	89
		load	1881	2557	2108	193	93
		domInteractive	31	90	44	15	7
		backgroundConnect	11	85	32	24	11
		firstReactRender	53	96	75	12	6
		getState	60	110	93	13	6
		initialActions	0	0	0	0	0
		loadScripts	1365	1962	1575	165	79
		setupStore	7	55	11	10	5
		uiStartup	2133	2921	2403	227	109

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 22 Bytes (0.00%)
ui: 10.13 KiB (0.13%)
common: 934 Bytes (0.01%)

bergeron · 2024-11-19T22:21:35Z

privacy-snapshot.json

@@ -29,6 +29,8 @@
  "github.com",
  "goerli.infura.io",
  "lattice.gridplus.io",
+  "linea-mainnet.infura.io",


Can these be removed now that more stuff is mocked?

I added mocks for the test that was failing test/e2e/tests/settings/account-token-list.spec.js
But I still had to add sepolia.infura.io to privacy snapshot

metamaskbot · 2024-11-20T00:23:21Z

Builds ready [d380413]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2051 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1811	2301	2048	107	51
		domContentLoaded	1799	2279	2010	105	50
		load	1810	2307	2051	115	55
		domInteractive	28	88	45	13	6
		backgroundConnect	10	135	40	36	17
		firstReactRender	58	376	150	97	47
		getState	52	201	118	46	22
		initialActions	0	1	0	0	0
		loadScripts	1349	1787	1529	105	51
		setupStore	6	46	11	8	4
		uiStartup	2126	2988	2508	278	134

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 22 Bytes (0.00%)
ui: 10.13 KiB (0.13%)
common: 934 Bytes (0.01%)

bergeron · 2024-11-20T00:40:45Z

privacy-snapshot.json

@@ -52,12 +52,13 @@
  "security-alerts.api.cx.metamask.io",
  "security-alerts.dev-api.cx.metamask.io",
  "sentry.io",
+  "sepolia.infura.io",


we'd prefer to mock all places hitting this. I think we expected #28277 to cover all places and, aren't sure which caller remains.

Agree; Inspecting the network tab on the test test/e2e/tests/settings/account-token-list.spec.js; the calls to infura that i see are eth_blockNumber, even though i added a mock for those, it is still requiring the snapshot update; not quite sure what i missed there

metamaskbot · 2024-11-20T01:07:50Z

Builds ready [fd49581]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2165 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	532	2417	2084	387	186
		domContentLoaded	1838	2405	2127	150	72
		load	1845	2421	2165	153	73
		domInteractive	29	80	45	14	7
		backgroundConnect	9	77	42	24	12
		firstReactRender	61	274	105	43	21
		getState	46	120	85	22	10
		initialActions	0	0	0	0	0
		loadScripts	1390	1850	1602	130	62
		setupStore	7	52	12	10	5
		uiStartup	2285	2842	2528	156	75

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 22 Bytes (0.00%)
ui: 10.13 KiB (0.13%)
common: 934 Bytes (0.01%)

bergeron and others added 30 commits October 22, 2024 14:30

bump asset controllers to 39

85fe12d

update ConfirmTransaction

0f3cd64

fix useGasFeeEstimates unit test

bdf921b

fix usePolling tests

9bc4ecf

bump controller utils

9b1529b

remove patch

c8bcc0b

Merge branch 'develop' into brian/asset-controller-39

d1a3782

Update LavaMoat policies

05fd6ef

lint

9dfdfa8

Merge branch 'brian/asset-controller-39' of github.com:MetaMask/metam…

04ea3d6

…ask-extension into brian/asset-controller-39

Merge branch 'develop' into brian/asset-controller-39

cf66072

initial multi chain polling for currency and token rates

785de28

fix testnets

f461767

only refetch prices on chains whose tokens changed

f1da818

poll multiple native currencies

878f407

fix test

e8a9d6a

yarn dedupe

245f8d3

Update LavaMoat policies

1afebee

Merge branch 'develop' into brian/currency-rate-multichain-polling2

e99e2ef

fix e2e test mocks

ca590ec

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

d2191ac

… brian/currency-rate-multichain-polling2

fix e2e test

70c0db4

.

6b7df4d

lint

4e816c2

fix e2e test

aaef377

Merge branch 'brian/currency-rate-multichain-polling2' of github.com:…

48bff46

…MetaMask/metamask-extension into brian/multiexchangerate

package.json

0450b04

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

fdc04ad

… brian/multiexchangerate

bump controller preview version

3ec3574

Merge branch 'develop' into brian/multiexchangerate

dcc8a64

sahar-fehri dismissed gambinish’s stale review via 04505e4 November 19, 2024 17:55

sahar-fehri added 4 commits November 19, 2024 19:07

fix: fix unit test

31a6b36

fix: add unit test

48312b7

fix: update popover text

69c9d5b

fix: fix import

69ed10a

gambinish previously approved these changes Nov 19, 2024

View reviewed changes

Merge branch 'develop' into feat/cross-chain-aggregated-balance

30ffad5

darkwing previously approved these changes Nov 19, 2024

View reviewed changes

bergeron reviewed Nov 19, 2024

View reviewed changes

sahar-fehri mentioned this pull request Nov 19, 2024

fix: add aggregated balance to account picker #27571

Closed

7 tasks

fix: rm privacy snapshot updates

0c058aa

sahar-fehri dismissed stale reviews from darkwing and gambinish via 0c058aa November 19, 2024 22:42

fix: add mock for e2e and update privacy snapshot

d380413

gambinish approved these changes Nov 20, 2024

View reviewed changes

bergeron approved these changes Nov 20, 2024

View reviewed changes

Merge branch 'develop' into feat/cross-chain-aggregated-balance

fd49581

darkwing approved these changes Nov 20, 2024

View reviewed changes

bergeron reviewed Nov 20, 2024

View reviewed changes

DDDDDanica approved these changes Nov 20, 2024

View reviewed changes

salimtb approved these changes Nov 20, 2024

View reviewed changes

sahar-fehri added this pull request to the merge queue Nov 20, 2024

Merged via the queue into develop with commit 4cfd133 Nov 20, 2024
75 checks passed

sahar-fehri deleted the feat/cross-chain-aggregated-balance branch November 20, 2024 14:00

github-actions bot locked and limited conversation to collaborators Nov 20, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cross chain aggregated balance #28456

feat: cross chain aggregated balance #28456

sahar-fehri commented Nov 14, 2024 •

edited

Loading

gambinish left a comment

metamaskbot commented Nov 19, 2024

bergeron Nov 19, 2024

sahar-fehri Nov 20, 2024

metamaskbot commented Nov 20, 2024

bergeron Nov 20, 2024

sahar-fehri Nov 20, 2024 •

edited

Loading

metamaskbot commented Nov 20, 2024

feat: cross chain aggregated balance #28456

feat: cross chain aggregated balance #28456

Conversation

sahar-fehri commented Nov 14, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

gambinish left a comment

Choose a reason for hiding this comment

metamaskbot commented Nov 19, 2024

bergeron Nov 19, 2024

Choose a reason for hiding this comment

sahar-fehri Nov 20, 2024

Choose a reason for hiding this comment

metamaskbot commented Nov 20, 2024

bergeron Nov 20, 2024

Choose a reason for hiding this comment

sahar-fehri Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Nov 20, 2024

sahar-fehri commented Nov 14, 2024 •

edited

Loading

sahar-fehri Nov 20, 2024 •

edited

Loading