feat: cross chain swap STX

[infiniteflower]

Description

This PR improves support for Smart Transactions (STX). It will not show the STX status page if the tx is a Bridge tx. Instead users will be immediately sent to the Activity list. If the user opens the Bridge tx detaills, they should be able to see the proper info.

The main change is that in BridgeStatusController the txHistory is now keyed by txMeta.id rather than txMeta.hash. This is because for an STX we might not have the hash immediately, but we still want to look things up.

We also add a way to call addTransaction from the UI side. Previously we used addTransactionAndWaitForPublish. However for STX, this will cause the app to wait until a txHash is available before returning a txMeta, which means we can't even use the txMeta.id to key a BridgeHistoryItem. If we use addTransaction this will allow us to receive a txMeta object back immediately and use txMeta.id.

Related issues

Depends on MetaMask/core#4918

Manual testing steps

1. Go to Settings > Advanced, make sure Smart Transactions is on
2. Switch network to Ethereum
3. Go to Bridge
4. Selection source network, source token, dest network, dest token
5. Request a quote
6. Execute a bridge
7. Go to Activity
8. Click on the Bridge tx

Screenshots/Recordings

Before

After

Screen.Recording.2024-11-25.at.11.05.55.AM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [098d118]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1915 ± 151 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	361	3045	1750	560	269
		domContentLoaded	1544	2960	1880	309	148
		load	1553	3023	1915	315	151
		domInteractive	21	74	44	17	8
		backgroundConnect	9	81	37	23	11
		firstReactRender	16	83	32	22	11
		getState	5	66	24	20	10
		initialActions	0	1	0	0	0
		loadScripts	1142	2079	1366	213	103
		setupStore	6	56	15	15	7
		uiStartup	1696	3198	2117	327	157

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -289 Bytes (-0.00%)
• ui: 37.58 KiB (0.48%)
• common: 2.85 KiB (0.03%)

[metamaskbot]

Builds ready [5b2b7fb]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1707 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1548	1958	1711	118	57
		domContentLoaded	1533	1908	1682	111	53
		load	1546	1960	1707	123	59
		domInteractive	24	118	49	26	12
		backgroundConnect	10	99	27	24	11
		firstReactRender	16	75	45	23	11
		getState	5	62	17	19	9
		initialActions	0	1	0	0	0
		loadScripts	1102	1434	1234	97	47
		setupStore	6	58	15	16	8
		uiStartup	1723	2262	1936	149	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -289 Bytes (-0.00%)
• ui: 37.6 KiB (0.48%)
• common: 2.85 KiB (0.03%)

[metamaskbot]

Builds ready [1d50d37]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2099 ± 218 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	310	2980	1604	773	371
		domContentLoaded	1576	2932	2075	448	215
		load	1585	2977	2099	454	218
		domInteractive	23	115	50	27	13
		backgroundConnect	7	70	28	21	10
		firstReactRender	15	93	31	20	10
		getState	48	211	100	34	16
		initialActions	0	1	0	0	0
		loadScripts	1122	2275	1578	357	171
		setupStore	6	42	9	8	4
		uiStartup	1804	3335	2396	497	238

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -563 Bytes (-0.01%)
• ui: 37.75 KiB (0.48%)
• common: 2.85 KiB (0.03%)

[metamaskbot]

Builds ready [391eef3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1943 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1765	2348	1949	139	67
		domContentLoaded	1750	2231	1923	124	59
		load	1766	2261	1943	128	61
		domInteractive	26	67	39	12	6
		backgroundConnect	10	53	19	12	6
		firstReactRender	15	82	26	18	9
		getState	52	110	95	13	6
		initialActions	0	0	0	0	0
		loadScripts	1322	1739	1484	116	56
		setupStore	6	12	8	2	1
		uiStartup	2033	2528	2220	159	76

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: -563 Bytes (-0.01%)
• ui: 37.75 KiB (0.48%)
• common: 2.85 KiB (0.03%)