test: Fixed artifacts issue due to switching window title #28469

hjetpoluru · 2024-11-14T19:59:51Z

Description

This PR addresses the issue where artifacts are not generated when a timeout occurs during the switching window and the dialog does not appear, making it difficult to determine what has happened during the test scenario.

The fix ensures that an error is generated when a timeout occurs and is correctly returned. If the dialog is found, no error is generated. Special thanks to @davidmurdoch for pair programming, understanding the issue and suggesting the fix.

Related issues

Fixes:
#28116

Manual testing steps

All the artifacts needs to be generated.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-14T20:00:04Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-11-14T21:25:53Z

Builds ready [3b58c8e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1987 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	349	2299	1911	386	186
		domContentLoaded	1759	2213	1958	139	67
		load	1775	2344	1987	153	73
		domInteractive	30	207	53	37	18
		backgroundConnect	7	95	23	22	11
		firstReactRender	55	302	122	52	25
		getState	5	94	35	29	14
		initialActions	0	1	0	0	0
		loadScripts	1263	1683	1450	122	59
		setupStore	5	92	20	27	13
		uiStartup	1960	2955	2255	249	120

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-15T13:16:43Z

Builds ready [1aae3e1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1795 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1664	2240	1816	139	67
		domContentLoaded	1644	2143	1772	121	58
		load	1650	2254	1795	141	68
		domInteractive	30	76	44	14	7
		backgroundConnect	9	112	26	25	12
		firstReactRender	55	307	107	48	23
		getState	6	49	11	9	4
		initialActions	0	1	0	0	0
		loadScripts	1200	1572	1310	88	42
		setupStore	5	98	17	24	11
		uiStartup	1849	2598	2024	203	98

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

… fix-artifact-issue-28116

metamaskbot · 2024-11-15T14:31:01Z

Builds ready [8199f16]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1839 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	291	2414	1766	388	186
		domContentLoaded	1594	2309	1799	170	81
		load	1608	2398	1839	188	90
		domInteractive	13	172	55	35	17
		backgroundConnect	9	92	42	28	14
		firstReactRender	51	114	93	18	8
		getState	4	54	18	17	8
		initialActions	0	1	0	0	0
		loadScripts	1153	1787	1330	155	75
		setupStore	5	51	9	10	5
		uiStartup	1817	2634	2030	198	95

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

HowardBraham

I tested the failure on develop and there are no artifacts, but artifacts show up on this branch

metamaskbot · 2024-11-21T21:43:10Z

Builds ready [cd47698]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1841 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	230	2182	1755	379	182
		domContentLoaded	1554	2001	1797	122	59
		load	1563	2181	1841	149	72
		domInteractive	15	290	63	74	35
		backgroundConnect	6	292	45	61	29
		firstReactRender	44	287	143	69	33
		getState	5	97	12	20	10
		initialActions	0	1	0	0	0
		loadScripts	1134	1552	1332	111	53
		setupStore	6	81	16	21	10
		uiStartup	1829	2707	2117	216	104

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Fixed the artifacts issue due to switching window title

33f9c0f

hjetpoluru added team-extension-platform INVALID-PR-TEMPLATE PR's body doesn't match template area-qa Relating to QA work (Quality Assurance) labels Nov 14, 2024

hjetpoluru self-assigned this Nov 14, 2024

metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 14, 2024

Fixed lint

fa77a0f

davidmurdoch requested a review from HowardBraham November 14, 2024 20:37

Merge branch 'develop' into fix-artifact-issue-28116

3b58c8e

Merge branch 'develop' into fix-artifact-issue-28116

1aae3e1

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

8199f16

… fix-artifact-issue-28116

HowardBraham approved these changes Nov 19, 2024

View reviewed changes

hjetpoluru marked this pull request as ready for review November 20, 2024 13:28

hjetpoluru requested a review from a team as a code owner November 20, 2024 13:28

hjetpoluru requested review from davidmurdoch, seaona and chloeYue November 21, 2024 20:28

DDDDDanica approved these changes Nov 21, 2024

View reviewed changes

hjetpoluru enabled auto-merge November 21, 2024 21:08

Merge branch 'develop' into fix-artifact-issue-28116

cd47698

hjetpoluru added this pull request to the merge queue Nov 21, 2024

Merged via the queue into develop with commit e748576 Nov 21, 2024
75 checks passed

hjetpoluru deleted the fix-artifact-issue-28116 branch November 21, 2024 21:53

github-actions bot locked and limited conversation to collaborators Nov 21, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Fixed artifacts issue due to switching window title #28469

test: Fixed artifacts issue due to switching window title #28469

hjetpoluru commented Nov 14, 2024 •

edited

Loading

github-actions bot commented Nov 14, 2024

metamaskbot commented Nov 14, 2024

metamaskbot commented Nov 15, 2024

metamaskbot commented Nov 15, 2024

HowardBraham left a comment

metamaskbot commented Nov 21, 2024

test: Fixed artifacts issue due to switching window title #28469

test: Fixed artifacts issue due to switching window title #28469

Conversation

hjetpoluru commented Nov 14, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 14, 2024

metamaskbot commented Nov 14, 2024

metamaskbot commented Nov 15, 2024

metamaskbot commented Nov 15, 2024

HowardBraham left a comment

Choose a reason for hiding this comment

metamaskbot commented Nov 21, 2024

hjetpoluru commented Nov 14, 2024 •

edited

Loading