Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changing title for permit requests #28537

Merged
merged 53 commits into from
Nov 26, 2024
Merged

feat: Changing title for permit requests #28537

merged 53 commits into from
Nov 26, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 19, 2024

Description

Change title and description for permit pages.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3633

Manual testing steps

  1. Enable permit signature decoding locally
  2. Go to test dapp
  3. Check title and description of permit pages

Screenshots/Recordings

Screenshot 2024-11-19 at 3 46 02 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri and others added 30 commits November 7, 2024 14:56
@jpuri jpuri requested a review from a team as a code owner November 19, 2024 10:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b5f0ef7]
Page Load Metrics (1847 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15872317184719995
domContentLoaded15742306180918991
load16662320184719594
domInteractive1510241178
backgroundConnect9101352613
firstReactRender552931055125
getState47015168
initialActions01000
loadScripts11241782132615976
setupStore56013168
uiStartup187425262076210101
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -106.79 KiB (-1.76%)
  • ui: 8.08 KiB (0.10%)
  • common: 107.3 KiB (1.30%)

matthewwalsh0
matthewwalsh0 previously approved these changes Nov 22, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [9ac696e]
Page Load Metrics (1885 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16702253189211756
domContentLoaded16612155184910350
load16702263188512259
domInteractive25150493216
backgroundConnect10144333316
firstReactRender703871336431
getState598242713
initialActions01000
loadScripts1191161713569244
setupStore65112136
uiStartup188530602148239115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -577 Bytes (-0.01%)
  • common: -4 Bytes (-0.00%)

Base automatically changed from simulation_message_change to develop November 25, 2024 15:32
@jpuri jpuri dismissed matthewwalsh0’s stale review November 25, 2024 15:32

The base branch was changed.

@metamaskbot
Copy link
Collaborator

Builds ready [b303f0d]
Page Load Metrics (1828 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16192372182518589
domContentLoaded16042229178215876
load16202350182817785
domInteractive259039188
backgroundConnect11112433014
firstReactRender1780372311
getState574292110
initialActions01000
loadScripts11701677131213866
setupStore55610115
uiStartup180827272033209100
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -577 Bytes (-0.01%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [7b79b13]
Page Load Metrics (1912 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint160625281905225108
domContentLoaded158424901867221106
load166425661912229110
domInteractive2588462211
backgroundConnect1099492813
firstReactRender197135189
getState57721199
initialActions09121
loadScripts11251857136818790
setupStore75116157
uiStartup181129822133265127
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -577 Bytes (-0.01%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 6830a39 Nov 26, 2024
75 checks passed
@jpuri jpuri deleted the permit_title_changes branch November 26, 2024 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants